Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: chrome/browser/prerender/prerender_tracker_unittest.cc

Issue 407093011: Allow URLRequests from one context to have different NetworkDelegates. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: And fix more stuff... Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_tracker_unittest.cc
diff --git a/chrome/browser/prerender/prerender_tracker_unittest.cc b/chrome/browser/prerender/prerender_tracker_unittest.cc
index fa4330e6d844ce8773efda687583c464df627009..1c98a716dc80c799b5e9881641466d9ce7bde0de 100644
--- a/chrome/browser/prerender/prerender_tracker_unittest.cc
+++ b/chrome/browser/prerender/prerender_tracker_unittest.cc
@@ -223,21 +223,21 @@ TEST_F(PrerenderTrackerTest, PrerenderThrottledRedirectResume) {
// Fake a request.
net::TestURLRequestContext url_request_context;
DeferredRedirectDelegate delegate;
- net::URLRequest request(
+ scoped_ptr<net::URLRequest> request(url_request_context.CreateRequest(
content::URLRequestMockHTTPJob::GetMockUrl(base::FilePath(kRedirectPath)),
net::DEFAULT_PRIORITY,
&delegate,
- &url_request_context);
+ NULL));
content::ResourceRequestInfo::AllocateForTesting(
- &request, ResourceType::IMAGE, NULL,
+ request.get(), ResourceType::IMAGE, NULL,
kDefaultChildId, kDefaultRouteId, MSG_ROUTING_NONE, true);
// Install a prerender throttle.
- PrerenderResourceThrottle throttle(&request);
+ PrerenderResourceThrottle throttle(request.get());
delegate.SetThrottle(&throttle);
// Start the request and wait for a redirect.
- request.Start();
+ request->Start();
delegate.Run();
EXPECT_TRUE(delegate.was_deferred());
// This calls WillRedirectRequestOnUI().
@@ -262,22 +262,22 @@ TEST_F(PrerenderTrackerTest, PrerenderThrottledRedirectMainFrame) {
// Fake a request.
net::TestURLRequestContext url_request_context;
DeferredRedirectDelegate delegate;
- net::URLRequest request(
+ scoped_ptr<net::URLRequest> request(url_request_context.CreateRequest(
content::URLRequestMockHTTPJob::GetMockUrl(base::FilePath(kRedirectPath)),
net::DEFAULT_PRIORITY,
&delegate,
- &url_request_context);
+ NULL));
content::ResourceRequestInfo::AllocateForTesting(
- &request, ResourceType::MAIN_FRAME, NULL,
+ request.get(), ResourceType::MAIN_FRAME, NULL,
kDefaultChildId, kDefaultRouteId, MSG_ROUTING_NONE, true);
// Install a prerender throttle.
- PrerenderResourceThrottle throttle(&request);
+ PrerenderResourceThrottle throttle(request.get());
delegate.SetThrottle(&throttle);
// Start the request and wait for a redirect. This time, it should
// not be deferred.
- request.Start();
+ request->Start();
delegate.Run();
// This calls WillRedirectRequestOnUI().
RunEvents();
@@ -299,21 +299,21 @@ TEST_F(PrerenderTrackerTest, PrerenderThrottledRedirectSyncXHR) {
// Fake a request.
net::TestURLRequestContext url_request_context;
DeferredRedirectDelegate delegate;
- net::URLRequest request(
+ scoped_ptr<net::URLRequest> request(url_request_context.CreateRequest(
content::URLRequestMockHTTPJob::GetMockUrl(base::FilePath(kRedirectPath)),
net::DEFAULT_PRIORITY,
&delegate,
- &url_request_context);
+ NULL));
content::ResourceRequestInfo::AllocateForTesting(
- &request, ResourceType::XHR, NULL,
+ request.get(), ResourceType::XHR, NULL,
kDefaultChildId, kDefaultRouteId, MSG_ROUTING_NONE, false);
// Install a prerender throttle.
- PrerenderResourceThrottle throttle(&request);
+ PrerenderResourceThrottle throttle(request.get());
delegate.SetThrottle(&throttle);
// Start the request and wait for a redirect.
- request.Start();
+ request->Start();
delegate.Run();
// This calls WillRedirectRequestOnUI().
RunEvents();

Powered by Google App Engine
This is Rietveld 408576698