Allow URLRequests from one context to have different NetworkDelegates.

extensions/browser/extension_protocols_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/file_util.h"
+#include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/values.h"
 #include "chrome/common/chrome_paths.h"
 //#include "chrome/common/url_constants.h"
 #include "content/public/browser/resource_request_info.h"
 #include "content/public/test/mock_resource_context.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "extensions/browser/extension_protocols.h"
@@ skipping 152 matching lines @@
     scoped_refptr<Extension> extension =
         CreateTestExtension(cases[i].name, cases[i].incognito_split_mode);
     extension_info_map_->AddExtension(
         extension.get(), base::Time::Now(), cases[i].incognito_enabled, false);
 
     // First test a main frame request.
     {
       // It doesn't matter that the resource doesn't exist. If the resource
       // is blocked, we should see ADDRESS_UNREACHABLE. Otherwise, the request
       // should just fail because the file doesn't exist.
-      net::URLRequest request(extension->GetResourceURL("404.html"),
-                              net::DEFAULT_PRIORITY,
-                              &test_delegate_,
-                              resource_context_.GetRequestContext());
-      StartRequest(&request, content::RESOURCE_TYPE_MAIN_FRAME);
-      EXPECT_EQ(net::URLRequestStatus::FAILED, request.status().status());
+      scoped_ptr<net::URLRequest> request(
+          resource_context_.GetRequestContext()->CreateRequest(
+              extension->GetResourceURL("404.html"),
+              net::DEFAULT_PRIORITY,
+              &test_delegate_,
+              NULL));
+      StartRequest(request.get(), content::RESOURCE_TYPE_MAIN_FRAME);
+      EXPECT_EQ(net::URLRequestStatus::FAILED, request->status().status());
 
       if (cases[i].should_allow_main_frame_load) {
-        EXPECT_EQ(net::ERR_FILE_NOT_FOUND, request.status().error()) <<
+        EXPECT_EQ(net::ERR_FILE_NOT_FOUND, request->status().error()) <<
             cases[i].name;
       } else {
-        EXPECT_EQ(net::ERR_ADDRESS_UNREACHABLE, request.status().error()) <<
+        EXPECT_EQ(net::ERR_ADDRESS_UNREACHABLE, request->status().error()) <<
             cases[i].name;
       }
     }
 
     // Now do a subframe request.
     {
-      net::URLRequest request(extension->GetResourceURL("404.html"),
-                              net::DEFAULT_PRIORITY,
-                              &test_delegate_,
-                              resource_context_.GetRequestContext());
-      StartRequest(&request, content::RESOURCE_TYPE_SUB_FRAME);
-      EXPECT_EQ(net::URLRequestStatus::FAILED, request.status().status());
+      scoped_ptr<net::URLRequest> request(
+          resource_context_.GetRequestContext()->CreateRequest(
+              extension->GetResourceURL("404.html"),
+              net::DEFAULT_PRIORITY,
+              &test_delegate_,
+              NULL));
+      StartRequest(request.get(), content::RESOURCE_TYPE_SUB_FRAME);
+      EXPECT_EQ(net::URLRequestStatus::FAILED, request->status().status());
 
       if (cases[i].should_allow_sub_frame_load) {
-        EXPECT_EQ(net::ERR_FILE_NOT_FOUND, request.status().error()) <<
+        EXPECT_EQ(net::ERR_FILE_NOT_FOUND, request->status().error()) <<
             cases[i].name;
       } else {
-        EXPECT_EQ(net::ERR_ADDRESS_UNREACHABLE, request.status().error()) <<
+        EXPECT_EQ(net::ERR_ADDRESS_UNREACHABLE, request->status().error()) <<
             cases[i].name;
       }
     }
   }
 }
 
 void CheckForContentLengthHeader(net::URLRequest* request) {
   std::string content_length;
   request->GetResponseHeaderByName(net::HttpRequestHeaders::kContentLength,
                                   &content_length);
@@ skipping 10 matching lines @@
   SetProtocolHandler(false);
 
   scoped_refptr<Extension> extension = CreateWebStoreExtension();
   extension_info_map_->AddExtension(extension.get(),
                                     base::Time::Now(),
                                     false,
                                     false);
 
   // First test it with the extension enabled.
   {
-    net::URLRequest request(extension->GetResourceURL("webstore_icon_16.png"),
-                            net::DEFAULT_PRIORITY,
-                            &test_delegate_,
-                            resource_context_.GetRequestContext());
-    StartRequest(&request, content::RESOURCE_TYPE_MEDIA);
-    EXPECT_EQ(net::URLRequestStatus::SUCCESS, request.status().status());
-    CheckForContentLengthHeader(&request);
+    scoped_ptr<net::URLRequest> request(
+        resource_context_.GetRequestContext()->CreateRequest(
+            extension->GetResourceURL("webstore_icon_16.png"),
+            net::DEFAULT_PRIORITY,
+            &test_delegate_,
+            NULL));
+    StartRequest(request.get(), content::RESOURCE_TYPE_MEDIA);
+    EXPECT_EQ(net::URLRequestStatus::SUCCESS, request->status().status());
+    CheckForContentLengthHeader(request.get());
   }
 
   // And then test it with the extension disabled.
   extension_info_map_->RemoveExtension(extension->id(),
                                        UnloadedExtensionInfo::REASON_DISABLE);
   {
-    net::URLRequest request(extension->GetResourceURL("webstore_icon_16.png"),
-                            net::DEFAULT_PRIORITY,
-                            &test_delegate_,
-                            resource_context_.GetRequestContext());
-    StartRequest(&request, content::RESOURCE_TYPE_MEDIA);
-    EXPECT_EQ(net::URLRequestStatus::SUCCESS, request.status().status());
-    CheckForContentLengthHeader(&request);
+    scoped_ptr<net::URLRequest> request(
+        resource_context_.GetRequestContext()->CreateRequest(
+            extension->GetResourceURL("webstore_icon_16.png"),
+            net::DEFAULT_PRIORITY,
+            &test_delegate_,
+            NULL));
+    StartRequest(request.get(), content::RESOURCE_TYPE_MEDIA);
+    EXPECT_EQ(net::URLRequestStatus::SUCCESS, request->status().status());
+    CheckForContentLengthHeader(request.get());
   }
 }
 
 // Tests that a URL request for resource from an extension returns a few
 // expected response headers.
 TEST_F(ExtensionProtocolTest, ResourceRequestResponseHeaders) {
   // Register a non-incognito extension protocol handler.
   SetProtocolHandler(false);
 
   scoped_refptr<Extension> extension = CreateTestResponseHeaderExtension();
   extension_info_map_->AddExtension(extension.get(),
                                     base::Time::Now(),
                                     false,
                                     false);
 
   {
-    net::URLRequest request(extension->GetResourceURL("test.dat"),
-                            net::DEFAULT_PRIORITY,
-                            &test_delegate_,
-                            resource_context_.GetRequestContext());
-    StartRequest(&request, content::RESOURCE_TYPE_MEDIA);
-    EXPECT_EQ(net::URLRequestStatus::SUCCESS, request.status().status());
+    scoped_ptr<net::URLRequest> request(
+        resource_context_.GetRequestContext()->CreateRequest(
+            extension->GetResourceURL("test.dat"),
+            net::DEFAULT_PRIORITY,
+            &test_delegate_,
+            NULL));
+    StartRequest(request.get(), content::RESOURCE_TYPE_MEDIA);
+    EXPECT_EQ(net::URLRequestStatus::SUCCESS, request->status().status());
 
     // Check that cache-related headers are set.
     std::string etag;
-    request.GetResponseHeaderByName("ETag", &etag);
+    request->GetResponseHeaderByName("ETag", &etag);
     EXPECT_TRUE(StartsWithASCII(etag, "\"", false));
     EXPECT_TRUE(EndsWith(etag, "\"", false));
 
     std::string revalidation_header;
-    request.GetResponseHeaderByName("cache-control", &revalidation_header);
+    request->GetResponseHeaderByName("cache-control", &revalidation_header);
     EXPECT_EQ("no-cache", revalidation_header);
 
     // We set test.dat as web-accessible, so it should have a CORS header.
     std::string access_control;
-    request.GetResponseHeaderByName("Access-Control-Allow-Origin",
+    request->GetResponseHeaderByName("Access-Control-Allow-Origin",
                                     &access_control);
     EXPECT_EQ("*", access_control);
   }
 }
 
 // Tests that a URL request for main frame or subframe from an extension
 // succeeds, but subresources fail. See http://crbug.com/312269.
 TEST_F(ExtensionProtocolTest, AllowFrameRequests) {
   // Register a non-incognito extension protocol handler.
   SetProtocolHandler(false);
 
   scoped_refptr<Extension> extension = CreateTestExtension("foo", false);
   extension_info_map_->AddExtension(extension.get(),
                                     base::Time::Now(),
                                     false,
                                     false);
 
   // All MAIN_FRAME and SUB_FRAME requests should succeed.
   {
-    net::URLRequest request(extension->GetResourceURL("test.dat"),
-                            net::DEFAULT_PRIORITY,
-                            &test_delegate_,
-                            resource_context_.GetRequestContext());
-    StartRequest(&request, content::RESOURCE_TYPE_MAIN_FRAME);
-    EXPECT_EQ(net::URLRequestStatus::SUCCESS, request.status().status());
+    scoped_ptr<net::URLRequest> request(
+        resource_context_.GetRequestContext()->CreateRequest(
+            extension->GetResourceURL("test.dat"),
+            net::DEFAULT_PRIORITY,
+            &test_delegate_,
+            NULL));
+    StartRequest(request.get(), content::RESOURCE_TYPE_MAIN_FRAME);
+    EXPECT_EQ(net::URLRequestStatus::SUCCESS, request->status().status());
   }
   {
-    net::URLRequest request(extension->GetResourceURL("test.dat"),
-                            net::DEFAULT_PRIORITY,
-                            &test_delegate_,
-                            resource_context_.GetRequestContext());
-    StartRequest(&request, content::RESOURCE_TYPE_SUB_FRAME);
-    EXPECT_EQ(net::URLRequestStatus::SUCCESS, request.status().status());
+    scoped_ptr<net::URLRequest> request(
+        resource_context_.GetRequestContext()->CreateRequest(
+            extension->GetResourceURL("test.dat"),
+            net::DEFAULT_PRIORITY,
+            &test_delegate_,
+            NULL));
+    StartRequest(request.get(), content::RESOURCE_TYPE_SUB_FRAME);
+    EXPECT_EQ(net::URLRequestStatus::SUCCESS, request->status().status());
   }
 
   // And subresource types, such as media, should fail.
   {
-    net::URLRequest request(extension->GetResourceURL("test.dat"),
-                            net::DEFAULT_PRIORITY,
-                            &test_delegate_,
-                            resource_context_.GetRequestContext());
-    StartRequest(&request, content::RESOURCE_TYPE_MEDIA);
-    EXPECT_EQ(net::URLRequestStatus::FAILED, request.status().status());
+    scoped_ptr<net::URLRequest> request(
+        resource_context_.GetRequestContext()->CreateRequest(
+            extension->GetResourceURL("test.dat"),
+            net::DEFAULT_PRIORITY,
+            &test_delegate_,
+            NULL));
+    StartRequest(request.get(), content::RESOURCE_TYPE_MEDIA);
+    EXPECT_EQ(net::URLRequestStatus::FAILED, request->status().status());
   }
 }
 
 }  // namespace extensions