Source/core/dom/TreeScope.cpp - Issue 407093010: Simplify compareDocumentPosition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/TreeScope.cpp

Issue 407093010: Simplify compareDocumentPosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/TreeScope.cpp

diff --git a/Source/core/dom/TreeScope.cpp b/Source/core/dom/TreeScope.cpp

index 8d8496af20dbae5eeddbd87e71a2c414c93e53a6..b6734b9b1dd03fcce268f78ae8d5c2a1d1270245 100644

--- a/Source/core/dom/TreeScope.cpp

+++ b/Source/core/dom/TreeScope.cpp

@@ -405,7 +405,7 @@ unsigned short TreeScope::comparePosition(const TreeScope& otherScope) const

Node* shadowHost1 = child1->rootNode().parentOrShadowHostNode();

Node* shadowHost2 = child2->rootNode().parentOrShadowHostNode();

if (shadowHost1 != shadowHost2)

- return shadowHost1->compareDocumentPositionInternal(shadowHost2, Node::TreatShadowTreesAsDisconnected);

+ return shadowHost1->compareDocumentPosition(shadowHost2, Node::TreatShadowTreesAsDisconnected);

for (const ShadowRoot* child = toShadowRoot(child2->rootNode()).olderShadowRoot(); child; child = child->olderShadowRoot())

if (child == child1)

« no previous file with comments | « Source/core/dom/StyleEngine.cpp ('k') | no next file » | no next file with comments »