Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 407093003: Switch from ELF CPU-specific to OS-specific DT_ tags. (Closed)

Created:
6 years, 5 months ago by simonb (inactive)
Modified:
6 years, 5 months ago
Reviewers:
rmcilroy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Switch from ELF CPU-specific to OS-specific DT_ tags. Use the OS-specific range for packed relocation extension DT_ tags. Name throughout as DT_ANDROID_REL_ rather than DT_ANDROID_ARM_REL_. Change test data to match. BUG=385553 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285179

Patch Set 1 #

Patch Set 2 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M third_party/android_crazy_linker/README.chromium View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/android_crazy_linker/src/src/crazy_linker_shared_library.cpp View 2 chunks +11 lines, -7 lines 0 comments Download
M tools/relocation_packer/README.TXT View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/relocation_packer/src/elf_file.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/relocation_packer/test_data/elf_file_unittest_relocs_packed.so View Binary file 0 comments Download

Messages

Total messages: 12 (0 generated)
simonb (inactive)
6 years, 5 months ago (2014-07-22 12:08:22 UTC) #1
rmcilroy
lgtm, thanks.
6 years, 5 months ago (2014-07-22 16:00:23 UTC) #2
simonb (inactive)
The CQ bit was checked by simonb@chromium.org
6 years, 5 months ago (2014-07-22 19:49:33 UTC) #3
simonb (inactive)
The CQ bit was unchecked by simonb@chromium.org
6 years, 5 months ago (2014-07-22 19:50:58 UTC) #4
simonb (inactive)
The CQ bit was checked by simonb@chromium.org
6 years, 5 months ago (2014-07-23 16:26:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonb@chromium.org/407093003/20001
6 years, 5 months ago (2014-07-23 16:27:32 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 19:16:02 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 19:38:22 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/173885)
6 years, 5 months ago (2014-07-23 19:38:23 UTC) #9
simonb (inactive)
The CQ bit was checked by simonb@chromium.org
6 years, 5 months ago (2014-07-24 09:58:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonb@chromium.org/407093003/20001
6 years, 5 months ago (2014-07-24 09:59:10 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 10:57:45 UTC) #12
Message was sent while issue was closed.
Change committed as 285179

Powered by Google App Engine
This is Rietveld 408576698