Issue 407073006: fix android_framework build do to missing library at link time

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 407073006: fix android_framework build do to missing library at link time (Closed)

Created:
6 years, 5 months ago by djsollen

Modified:
6 years, 5 months ago

Reviewers:
scroggo

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

fix android_framework build do to missing library at link time Committed: https://skia.googlesource.com/skia/+/85d36525c613c6c94e1f1c5dc51c1a2f73a0bc9c

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	gyp/tests.gypi	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/407073006/1

6 years, 5 months ago (2014-07-22 20:44:13 UTC) #3

scroggo

On 2014/07/22 20:44:13, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...

6 years, 5 months ago (2014-07-22 20:44:57 UTC) #4

commit-bot: I haz the power

Change committed as 85d36525c613c6c94e1f1c5dc51c1a2f73a0bc9c

6 years, 5 months ago (2014-07-22 20:56:38 UTC) #5

scroggo

6 years, 5 months ago (2014-07-24 17:47:46 UTC) #6

Message was sent while issue was closed.

On 2014/07/22 20:44:57, scroggo wrote:
> On 2014/07/22 20:44:13, I haz the power (commit-bot) wrote:
> > CQ is trying da patch. Follow status at
> >  https://skia-tree-status.appspot.com/cq/djsollen@google.com/407073006/1
> 
> I approve because this fixes for now, but should we also make this align with
> SK_CAN_USE_DLOPEN?

Oh NVM, I think that's just for Skia. I think it's okay for tests to depend on
dlopen if the library does not.

Expand Messages | Collapse Messages