DescriptionRevert of High resolution timer fix for Windows (https://codereview.chromium.org/395913006/)
Reason for revert:
This patch seems to make following browser_tests flakey
PPAPINaClNewlibTest.Graphics2D_FlushOffscreenUpdate
NetInternalsTest.netInternalsHSTSViewAddOverwrite
NetInternalsTest.netInternalsHSTSViewAddDelete
NetInternalsTest.netInternalsHSTSViewAddTwice
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29/builds/34734
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32086
http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/47545
Original issue's description:
> This is jamesr@ code I am landing.
>
> On Windows the message pump code tried to manage the systemwide timer resolution to fire delayed tasks with better than 15ms resolution but it was buggy:
>
> 1- A short task that was not followed by any other task will leave the systemwide timer pegged to 1ms
>
> 2- After we decided to crank up the timer we would 'lease' the timer for 1 second, for no good reason.
>
> Both issues are detrimental to battery power.
>
> The source of both problems is that we tried to decide with incomplete information. This patch solves that by having 1 bit for each pending task that requires a high resolution timer and a sum of the number of tasks that require high res timers.
>
> BUG=153139
> TEST=included here, also see the bug for manual testing.
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284625
TBR=jamesr@chromium.org,darin@chromium.org,cpu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=153139
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284664
Patch Set 1 #
Created: 6 years, 5 months ago
(Patch set is too large to download)
Messages
Total messages: 5 (0 generated)
|