[SyncFS] Add completion callback to PromoteDemotedChanges (1/3)

[SyncFS] Add completion callback to PromoteDemotedChanges

Add completion callback as a parameter of PromoteDemotedChanges.
This is mainly for tests to wait for the completion of the operation.

BUG=344769
TEST=unit_tests --gtest_filter='DriveBackendSyncTest.*'

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284686

[tzik, 2014-07-22 07:07:03]

PTL

[peria, 2014-07-22 07:19:29]

lgtm with a nit.

https://codereview.chromium.org/407073003/diff/40001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/local/local_file_sync_service.cc (right):

https://codereview.chromium.org/407073003/diff/40001/chrome/browser/sync_file...
chrome/browser/sync_file_system/local/local_file_sync_service.cc:46: if
(!--*count)
nit:
Could you split this "if" statement?
Current statement looks difficult.


--(*count);
if (*count > 0)
  callback.Run();

[tzik, 2014-07-22 07:28:22]

https://codereview.chromium.org/407073003/diff/40001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/local/local_file_sync_service.cc (right):

https://codereview.chromium.org/407073003/diff/40001/chrome/browser/sync_file...
chrome/browser/sync_file_system/local/local_file_sync_service.cc:46: if
(!--*count)
On 2014/07/22 07:19:29, peria wrote:
> nit:
> Could you split this "if" statement?
> Current statement looks difficult.
> 
> 
> --(*count);
> if (*count > 0)
>   callback.Run();

Done.

[tzik, 2014-07-22 07:29:38]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-07-22 07:30:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tzik@chromium.org/407073003/60001

[commit-bot: I haz the power, 2014-07-22 09:19:04]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-22 10:27:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-22 10:27:04]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[tzik, 2014-07-22 11:24:33]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-07-22 11:25:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tzik@chromium.org/407073003/60001

[commit-bot: I haz the power, 2014-07-22 12:30:19]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-22 16:02:04]

Change committed as 284686