Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 407023002: Revert of [Telemetry] Disable a Dromaeo benchmark on XP due to OOM. (Closed)

Created:
6 years, 5 months ago by kouhei (in TOK)
Modified:
6 years, 5 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of [Telemetry] Disable a Dromaeo benchmark on XP due to OOM. (https://codereview.chromium.org/271583003/) Reason for revert: The issue is probably fixed by Blink r176006. Original issue's description: > [Telemetry] Disable a Dromaeo benchmark on XP due to OOM. > > BUG=323782 > NOTRY=True > TBR=dtu@chromium.org > NOTREECHECKS=True > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268666 NOTRY=true BUG=323782 TBR=tonyg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284583

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tools/perf/benchmarks/dromaeo.py View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
kouhei (in TOK)
Created Revert of [Telemetry] Disable a Dromaeo benchmark on XP due to OOM.
6 years, 5 months ago (2014-07-22 00:05:50 UTC) #1
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 5 months ago (2014-07-22 00:06:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/407023002/1
6 years, 5 months ago (2014-07-22 00:09:50 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 00:56:03 UTC) #4
commit-bot: I haz the power
Failed to apply patch for tools/perf/benchmarks/dromaeo.py: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 5 months ago (2014-07-22 00:56:04 UTC) #5
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 5 months ago (2014-07-22 01:01:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/407023002/40001
6 years, 5 months ago (2014-07-22 01:05:18 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 01:33:52 UTC) #8
Message was sent while issue was closed.
Change committed as 284583

Powered by Google App Engine
This is Rietveld 408576698