Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issue 407011: Merge 32441 - Change the folder presentation in the Bookmark Editor and the B... (Closed)

Created:
11 years, 1 month ago by mrossetti
Modified:
9 years, 7 months ago
Reviewers:
mrossetti
CC:
chromium-reviews_googlegroups.com, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Merge 32441 - Change the folder presentation in the Bookmark Editor and the Bookmark All Tabs dialogs to a tree view. Nib changes: Removed the NSBrowser and added an NSOutlineView. BUG=26647, 26643, 26718, 27634 TEST=Bring up the bookmark editor by controlclicking in the bookmarks bar and selecting Add Page... or by selecting the Bookmark this Page... menu item found in the Bookmarks menu. Observe that the folder presentation is now a tree view. Select any folder and click New Folder to verify that new folders can be added. Doubleclick on the newly created folder to change its name. Added folders will not commit until OK is pressed, which will require that a bookmark actually be added. Also bring up the Bookmark All Tabs dialog by controlclicking in the tab bar with more than one tab open and verify that the folder structure is shown in a tree view. Review URL: http://codereview.chromium.org/393006 TBR=mrossetti@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32460

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1295 lines, -588 lines) Patch
M chrome/app/nibs/BookmarkAllTabs.xib View 20 chunks +371 lines, -87 lines 0 comments Download
M chrome/app/nibs/BookmarkEditor.xib View 20 chunks +347 lines, -102 lines 0 comments Download
M chrome/browser/cocoa/bookmark_all_tabs_controller.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/bookmark_all_tabs_controller.mm View 4 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/cocoa/bookmark_all_tabs_controller_unittest.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/bookmark_editor_base_controller.h View 6 chunks +86 lines, -16 lines 0 comments Download
M chrome/browser/cocoa/bookmark_editor_base_controller.mm View 8 chunks +280 lines, -211 lines 0 comments Download
M chrome/browser/cocoa/bookmark_editor_base_controller_unittest.mm View 5 chunks +51 lines, -18 lines 0 comments Download
M chrome/browser/cocoa/bookmark_editor_controller.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/bookmark_editor_controller.mm View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/cocoa/bookmark_editor_controller_unittest.mm View 16 chunks +135 lines, -132 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
mrossetti
11 years, 1 month ago (2009-11-19 01:37:50 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698