Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 407003002: Revert 284518 "Disable a flaky test." (Closed)

Created:
6 years, 5 months ago by sky
Modified:
6 years, 5 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 284518 "Disable a flaky test." This broke compile on android: http://build.chromium.org/p/chromium/builders/Android/builds/26268/steps/compile/logs/stdio ../android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java:794: cannot find symbol symbol : class DisabledTest location: class org.chromium.android_webview.test.AwContentsClientShouldOverrideUrlLoadingTest @DisabledTest ^ 1 error > Disable a flaky test. > > BUG=395817 > TEST=none > TBR=joth > > Review URL: https://codereview.chromium.org/408043002 TBR=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284530

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M trunk/src/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sky
6 years, 5 months ago (2014-07-21 22:58:52 UTC) #1
sky
Committed patchset #1 manually as r284530 (tree was closed).
6 years, 5 months ago (2014-07-21 22:59:01 UTC) #2
Peter Kasting
6 years, 5 months ago (2014-07-21 23:04:22 UTC) #3
Message was sent while issue was closed.
Sorry :(

Powered by Google App Engine
This is Rietveld 408576698