Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(901)

Side by Side Diff: src/version.h

Issue 4070003: [Isolates] Convert more static data either to read-only or to per-isolate. (Closed)
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 42
43 // Calculate the V8 version string. 43 // Calculate the V8 version string.
44 static void GetString(Vector<char> str); 44 static void GetString(Vector<char> str);
45 45
46 // Calculate the SONAME for the V8 shared library. 46 // Calculate the SONAME for the V8 shared library.
47 static void GetSONAME(Vector<char> str); 47 static void GetSONAME(Vector<char> str);
48 48
49 static const char* GetVersion() { return version_string_; } 49 static const char* GetVersion() { return version_string_; }
50 50
51 private: 51 private:
52 // NOTE: can't make these really const because of test-version.cc.
52 static int major_; 53 static int major_;
53 static int minor_; 54 static int minor_;
54 static int build_; 55 static int build_;
55 static int patch_; 56 static int patch_;
56 static bool candidate_; 57 static bool candidate_;
57 static const char* soname_; 58 static const char* soname_;
58 static const char* version_string_; 59 static const char* version_string_;
59 60
60 // In test-version.cc. 61 // In test-version.cc.
61 friend void SetVersion(int major, int minor, int build, int patch, 62 friend void SetVersion(int major, int minor, int build, int patch,
62 bool candidate, const char* soname); 63 bool candidate, const char* soname);
63 }; 64 };
64 65
65 } } // namespace v8::internal 66 } } // namespace v8::internal
66 67
67 #endif // V8_VERSION_H_ 68 #endif // V8_VERSION_H_
OLDNEW
« src/frames.h ('K') | « src/unicode.cc ('k') | test/cctest/test-accessors.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698