Issue 4070003: [Isolates] Convert more static data either to read-only or to per-isolate.

Issue 4070003: [Isolates] Convert more static data either to read-only or to per-isolate. (Closed)

Created:
10 years, 2 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Dmitry Titov, yurys

CC:
v8-dev

Visibility:
Public.

Description

[Isolates] Convert more static data either to read-only or to per-isolate. Committed: http://code.google.com/p/v8/source/detail?r=5709

Patch Set 1 #

Total comments: 1

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+115 lines, -95 lines)			Patch
M	src/ast.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/codegen.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/debug.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/debug-agent.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/debug-agent.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/frames.h	View	2 chunks	+18 lines, -14 lines	1 comment	Download
M	src/frames.cc	View	7 chunks	+7 lines, -9 lines	0 comments	Download
M	src/frames-inl.h	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	src/full-codegen.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/isolate.h	View	4 chunks	+4 lines, -1 line	0 comments	Download
M	src/isolate.cc	View	3 chunks	+4 lines, -0 lines	0 comments	Download
M	src/liveedit.cc	View	2 chunks	+8 lines, -7 lines	0 comments	Download
M	src/log.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/log.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/log-utils.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/log-utils.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/mark-compact.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/parser.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform-posix.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform-win32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/profile-generator.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/profile-generator.cc	View	2 chunks	+7 lines, -5 lines	0 comments	Download
M	src/runtime.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/runtime.cc	View	8 chunks	+9 lines, -10 lines	0 comments	Download
M	src/token.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/token.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/top.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/unicode.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/unicode.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/version.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/cctest/test-accessors.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dmitry Titov

10 years, 1 month ago (2010-10-26 01:16:06 UTC) #2

LGTM with one note for your consideration:

http://codereview.chromium.org/4070003/diff/1/10
File src/frames.h (right):

http://codereview.chromium.org/4070003/diff/1/10#newcode196
src/frames.h:196: Code* LookupCode(Isolate* isolate) const {
"Lookup" made me think there is some hash table or other structure in which
we'll be looking up... Maybe just "GetCode"?

Expand Messages | Collapse Messages