Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 406943002: Add test WidgetTest.GestureEventDispatch (Closed)

Created:
6 years, 5 months ago by tdanderson
Modified:
6 years, 5 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add test WidgetTest.GestureEventDispatch Add the new unit test WidgetTest.GestureEventDispatch to verify that non-scroll gesture events are dispatched to the correct views in a view hierarchy and that the default gesture handler in RootView is set correctly. This replaces the test ViewTest.GestureEvent. BUG=395397 TEST=WidgetTest.GestureEventDispatch Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284751

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -78 lines) Patch
M ui/views/view_unittest.cc View 1 chunk +0 lines, -78 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 chunk +113 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tdanderson
Sadrul, can you please take a look?
6 years, 5 months ago (2014-07-21 20:42:42 UTC) #1
sadrul
lgtm
6 years, 5 months ago (2014-07-22 17:07:51 UTC) #2
tdanderson
The CQ bit was checked by tdanderson@chromium.org
6 years, 5 months ago (2014-07-22 17:19:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/406943002/1
6 years, 5 months ago (2014-07-22 17:20:19 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 19:18:13 UTC) #5
Message was sent while issue was closed.
Change committed as 284751

Powered by Google App Engine
This is Rietveld 408576698