Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Unified Diff: chrome/common/extensions/docs/server2/api_data_source.py

Issue 406933003: Docserver: Show callback parameters in all callback references. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase/Address comment Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/server2/api_data_source.py
diff --git a/chrome/common/extensions/docs/server2/api_data_source.py b/chrome/common/extensions/docs/server2/api_data_source.py
index 943c90e2c1618a5661bdfc4b75bd923f511f461b..348810270f5f3e1023b81548b61d4a40509de3d5 100644
--- a/chrome/common/extensions/docs/server2/api_data_source.py
+++ b/chrome/common/extensions/docs/server2/api_data_source.py
@@ -382,7 +382,8 @@ class _JSCModel(object):
if function.callback is not None:
# Show the callback as an extra parameter.
function_dict['parameters'].append(
- self._GenerateCallbackProperty(function.callback))
+ self._GenerateCallbackProperty(function.callback,
+ function_dict['callback']))
if len(function_dict['parameters']) > 0:
function_dict['parameters'][-1]['last'] = True
return function_dict
@@ -429,11 +430,13 @@ class _JSCModel(object):
callback_object.params = event.params
if event.callback:
callback_object.callback = event.callback
- callback_parameters = self._GenerateCallbackProperty(callback_object)
+ callback = self._GenerateFunction(callback_object)
+ callback_parameters = self._GenerateCallbackProperty(callback_object,
+ callback)
callback_parameters['last'] = True
event_dict['byName']['addListener'] = {
'name': 'addListener',
- 'callback': self._GenerateFunction(callback_object),
+ 'callback': callback,
'parameters': [callback_parameters]
}
with self._current_node.Descend(event.simple_name, ignore=('properties',)):
@@ -514,12 +517,13 @@ class _JSCModel(object):
return property_dict
- def _GenerateCallbackProperty(self, callback):
+ def _GenerateCallbackProperty(self, callback, callback_dict):
property_dict = {
'name': callback.simple_name,
'description': callback.description,
'optional': callback.optional,
- 'is_callback': True,
+ 'isCallback': True,
+ 'asFunction': callback_dict,
'id': _CreateId(callback, 'property'),
'simple_type': 'function',
}

Powered by Google App Engine
This is Rietveld 408576698