Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 406913002: Add operator<< for mojo::String for logging use (Closed)

Created:
6 years, 5 months ago by DaveMoore
Modified:
6 years, 4 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add operator<< for mojo::String for logging use BUG=NONE R=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285852

Patch Set 1 #

Patch Set 2 : Remove blank line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M mojo/public/cpp/bindings/string.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
DaveMoore
Remove blank line
6 years, 5 months ago (2014-07-21 19:26:57 UTC) #1
DaveMoore
6 years, 5 months ago (2014-07-21 19:27:06 UTC) #2
DaveMoore
On 2014/07/21 19:27:06, DaveMoore wrote: PTAL
6 years, 5 months ago (2014-07-24 16:32:40 UTC) #3
DaveMoore
6 years, 5 months ago (2014-07-24 16:33:26 UTC) #4
darin (slow to review)
LGTM
6 years, 5 months ago (2014-07-24 16:42:58 UTC) #5
DaveMoore
The CQ bit was checked by davemoore@chromium.org
6 years, 5 months ago (2014-07-24 16:51:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davemoore@chromium.org/406913002/20001
6 years, 5 months ago (2014-07-24 16:52:38 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 18:45:46 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 19:23:04 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_swarming/builds/1956)
6 years, 5 months ago (2014-07-24 19:23:05 UTC) #10
DaveMoore
The CQ bit was checked by davemoore@chromium.org
6 years, 4 months ago (2014-07-27 20:55:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davemoore@chromium.org/406913002/20001
6 years, 4 months ago (2014-07-27 20:56:22 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 00:34:04 UTC) #13
Message was sent while issue was closed. 
Change committed as 285852

Powered by Google App Engine
This is Rietveld 408576698