content/common/gpu/media/v4l2_video_encode_accelerator.cc - Issue 406893002: Fix DCHECKs in V4l2VideoDevice.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/v4l2_video_encode_accelerator.cc

Issue 406893002: Fix DCHECKs in V4l2VideoDevice. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address review comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/media/v4l2_video_encode_accelerator.cc

diff --git a/content/common/gpu/media/v4l2_video_encode_accelerator.cc b/content/common/gpu/media/v4l2_video_encode_accelerator.cc

index a5cb4fb00f87f7802c9661284de6ad4209e0b52e..bff2f23f7d61f2a086243d6d13da44e8678a7871 100644

--- a/content/common/gpu/media/v4l2_video_encode_accelerator.cc

+++ b/content/common/gpu/media/v4l2_video_encode_accelerator.cc

@@ -860,6 +860,7 @@ bool V4L2VideoEncodeAccelerator::SetOutputFormat(

bool V4L2VideoEncodeAccelerator::NegotiateInputFormat(

media::VideoFrame::Format input_format) {

+ DVLOG(3) << "NegotiateInputFormat()";

scherkus (not reviewing) 2014/08/21 21:37:54 use __func__ ?

wuchengli 2014/08/22 05:32:05 Most functions in this file use a plain string for

DCHECK(child_message_loop_proxy_->BelongsToCurrentThread());

DCHECK(!input_streamon_);

DCHECK(!output_streamon_);