Issue 406863003: Implement String.prototype.codePointAt and String.fromCodePoint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 406863003: Implement String.prototype.codePointAt and String.fromCodePoint. (Closed)

Created:
6 years, 5 months ago by Yang

Modified:
6 years, 5 months ago

Reviewers:
mathiasb, rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Implement String.prototype.codePointAt and String.fromCodePoint. Contributed by Mathias Bynens <mathiasb@opera.com>;. TBR=mathiasb@opera.com, rossberg@chromium.org BUG=v8:2840 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=22493

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+214 lines, -4 lines)			Patch
M	src/harmony-string.js	View	1 chunk	+59 lines, -3 lines	0 comments	Download
M	src/messages.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	test/mjsunit/harmony/string-codepointat.js	View	1 chunk	+91 lines, -0 lines	0 comments	Download
A	test/mjsunit/harmony/string-fromcodepoint.js	View	1 chunk	+62 lines, -0 lines	0 comments	Download
M	tools/generate-runtime-tests.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Yang

TBR because the actual code review already happened here: https://codereview.appspot.com/13816046/

6 years, 5 months ago (2014-07-21 08:38:17 UTC) #1

Yang

6 years, 5 months ago (2014-07-21 08:45:40 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r22493 (presubmit successful).