Issue 406743002: Make PaintInvalidation a DocumentLifecyle state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 406743002: Make PaintInvalidation a DocumentLifecyle state (Closed)

Created:
6 years, 5 months ago by Julien - ping for review

Modified:
6 years, 5 months ago

Reviewers:
dsinclair, abarth-chromium, leviw_travelin_and_unemployed

CC:
abarth-chromium, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-rendering, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rwlbuis, rune+blink, sof, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Make PaintInvalidation a DocumentLifecyle state PaintInvalidation is run for every frame so it makes sense to move it to be a first class citizen of our state machine. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178603

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -4 lines)			Patch
M	Source/core/dom/DocumentLifecycle.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	Source/core/dom/DocumentLifecycle.cpp	View	2 chunks	+15 lines, -1 line	0 comments	Download
M	Source/core/frame/FrameView.cpp	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	Source/core/rendering/compositing/RenderLayerCompositor.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Julien - ping for review

The CQ bit was checked by jchaffraix@chromium.org

6 years, 5 months ago (2014-07-21 23:41:49 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/406743002/1

6 years, 5 months ago (2014-07-21 23:42:30 UTC) #4

Message was sent while issue was closed.

Change committed as 178603

Expand Messages | Collapse Messages