Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 406693005: Revert "mac: Load the system hotkeys after launch." (Closed)

Created:
6 years, 5 months ago by ccameron
Modified:
6 years, 5 months ago
Reviewers:
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, James Su, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "mac: Load the system hotkeys after launch." BUG=395187 TBR=erikchen@chromium.org > mac: Load the system hotkeys after launch. > > Shortly after launch, the system hotkeys are loaded and parsed. If a hotkey is > reserved by the system, it is not passed to the renderer. This allows system > hotkeys like (cmd + `) to work even if a flash plugin is selected. > > Add a histogram to ensure that the system hotkey plist is being correctly > loaded and parsed. > > BUG=383558 > TEST=Open 2 Chrome windows. Navigate one to www.twitch.tv. The site should > include a flash plugin that automatically starts playing a video. Select the > flash plugin. The hotkey combination (cmd + `) should switch between the open > windows. The hotkey combination (cmd + L) should have no effect (it is a Chrome > hotkey, not a browser hotkey). > > Review URL: https://codereview.chromium.org/370293004 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284273

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1397 lines) Patch
A + chrome/browser/ui/cocoa/system_hotkey_map.h View 2 chunks +9 lines, -27 lines 0 comments Download
A + chrome/browser/ui/cocoa/system_hotkey_map.mm View 6 chunks +9 lines, -25 lines 0 comments Download
A + chrome/browser/ui/cocoa/system_hotkey_map_unittest.mm View 3 chunks +9 lines, -26 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/test/data/mac/mac_system_hotkeys.plist View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/browser/browser_main_loop.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D content/browser/cocoa/system_hotkey_helper_mac.h View 1 chunk +0 lines, -56 lines 0 comments Download
D content/browser/cocoa/system_hotkey_helper_mac.mm View 1 chunk +0 lines, -77 lines 0 comments Download
D content/browser/cocoa/system_hotkey_map.h View 1 chunk +0 lines, -62 lines 0 comments Download
D content/browser/cocoa/system_hotkey_map.mm View 1 chunk +0 lines, -147 lines 0 comments Download
D content/browser/cocoa/system_hotkey_map_unittest.mm View 1 chunk +0 lines, -68 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 4 chunks +0 lines, -30 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D content/test/data/mac/mac_system_hotkeys.plist View 1 chunk +0 lines, -866 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ccameron
The CQ bit was checked by ccameron@chromium.org
6 years, 5 months ago (2014-07-18 22:24:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/406693005/1
6 years, 5 months ago (2014-07-18 22:28:58 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-19 01:44:25 UTC) #3
Message was sent while issue was closed.
Change committed as 284273

Powered by Google App Engine
This is Rietveld 408576698