core/src/fxge/win32/fx_win32_gdipext.cpp - Issue 406683005: Fix remaining -Wdelete-non-virtual-dtor violations on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxge/win32/fx_win32_gdipext.cpp

Issue 406683005: Fix remaining -Wdelete-non-virtual-dtor violations on Windows. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: . Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fxge/win32/fx_win32_gdipext.cpp

diff --git a/core/src/fxge/win32/fx_win32_gdipext.cpp b/core/src/fxge/win32/fx_win32_gdipext.cpp

index 1aada3a1f36be58c4c4addd6866320f11e6680c6..82ff2be9523fcaf7f08fcbcd82c69e16acfb5ebe 100644

--- a/core/src/fxge/win32/fx_win32_gdipext.cpp

+++ b/core/src/fxge/win32/fx_win32_gdipext.cpp

@@ -1003,7 +1003,7 @@ BOOL CGdiplusExt::DrawPath(HDC hDC, const CFX_PathData* pPathData,

CallFunc(GdipDeleteGraphics)(pGraphics);

return TRUE;

}

-class GpStream : public IStream, public CFX_Object

+class GpStream FX_FINAL : public IStream, public CFX_Object

{

LONG m_RefCount;

int m_ReadPos;

« no previous file with comments | « core/src/fxge/win32/fx_win32_dwrite.cpp ('k') | no next file » | no next file with comments »