Issue 406683005: Fix remaining -Wdelete-non-virtual-dtor violations on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 406683005: Fix remaining -Wdelete-non-virtual-dtor violations on Windows. (Closed)

Created:
6 years, 5 months ago by Nico

Modified:
6 years, 5 months ago

Reviewers:
Bo Xu

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Visibility:
Public.

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
M	core/src/fxge/win32/fx_win32_device.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	core/src/fxge/win32/fx_win32_dwrite.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	core/src/fxge/win32/fx_win32_gdipext.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Nico

6 years, 5 months ago (2014-07-21 16:51:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as rbaca770 (presubmit successful).