Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 406683004: Add more components tests to the GN build. (Closed)

Created:
6 years, 5 months ago by brettw
Modified:
6 years, 5 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, tfarina
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -3 lines) Patch
M components/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M components/bookmarks/browser/BUILD.gn View 1 1 chunk +15 lines, -0 lines 0 comments Download
M components/captive_portal/BUILD.gn View 1 1 chunk +11 lines, -0 lines 0 comments Download
M components/cloud_devices/common/BUILD.gn View 1 1 chunk +13 lines, -0 lines 0 comments Download
M components/components_tests.gyp View 2 chunks +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/browser/BUILD.gn View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/common/BUILD.gn View 1 chunk +11 lines, -0 lines 0 comments Download
M components/dom_distiller/core/BUILD.gn View 1 2 3 chunks +29 lines, -2 lines 0 comments Download
M components/domain_reliability/BUILD.gn View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
6 years, 5 months ago (2014-07-18 21:25:24 UTC) #1
viettrungluu
lgtm
6 years, 5 months ago (2014-07-18 21:33:54 UTC) #2
brettw
6 years, 5 months ago (2014-07-21 17:24:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r284450.

Powered by Google App Engine
This is Rietveld 408576698