Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 406683002: Move early return out of RootView::DispatchGestureEvent() (Closed)

Created:
6 years, 5 months ago by tdanderson
Modified:
6 years, 5 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move early return out of RootView::DispatchGestureEvent() In preparation for the eventual removal of RootView::DispatchGestureEvent(), move an early return out of this function and into RootView::OnEventFromSource(). This condition ignores any gesture-scroll events which were not preceded by a ui::ET_GESTURE_SCROLL_BEGIN event. BUG=353641 TEST=Tested by WidgetTest.GestureScrollEventDispatching Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284446

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -18 lines) Patch
M ui/views/widget/root_view.cc View 1 2 chunks +21 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
tdanderson
Sadrul, can you please take a look?
6 years, 5 months ago (2014-07-18 18:55:47 UTC) #1
sadrul
lgtm https://codereview.chromium.org/406683002/diff/1/ui/views/widget/root_view.cc File ui/views/widget/root_view.cc (right): https://codereview.chromium.org/406683002/diff/1/ui/views/widget/root_view.cc#newcode279 ui/views/widget/root_view.cc:279: } Let's get rid of the elses in ...
6 years, 5 months ago (2014-07-21 06:40:30 UTC) #2
tdanderson
https://codereview.chromium.org/406683002/diff/1/ui/views/widget/root_view.cc File ui/views/widget/root_view.cc (right): https://codereview.chromium.org/406683002/diff/1/ui/views/widget/root_view.cc#newcode279 ui/views/widget/root_view.cc:279: } On 2014/07/21 06:40:30, sadrul wrote: > Let's get ...
6 years, 5 months ago (2014-07-21 14:27:40 UTC) #3
tdanderson
The CQ bit was checked by tdanderson@chromium.org
6 years, 5 months ago (2014-07-21 14:27:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/406683002/20001
6 years, 5 months ago (2014-07-21 14:28:44 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 16:21:53 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-21 16:24:42 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds/161147)
6 years, 5 months ago (2014-07-21 16:24:43 UTC) #8
tdanderson
The CQ bit was checked by tdanderson@chromium.org
6 years, 5 months ago (2014-07-21 16:43:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/406683002/20001
6 years, 5 months ago (2014-07-21 16:44:51 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 16:51:13 UTC) #11
Message was sent while issue was closed.
Change committed as 284446

Powered by Google App Engine
This is Rietveld 408576698