Introduce skia_pic gyp variable.

gyp/common_variables.gypi

 # Copyright 2012 The Android Open Source Project
 #
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   # Get ready for the ugly...
   #
   # - We have to nest our variables dictionaries multiple levels deep, so that
   #   this and other gyp files can rely on previously-set variable values in
@@ skipping 162 matching lines @@
       }, {
         'skia_release_optimization_level%': '<(skia_default_gcc_optimization_level)',
       }],
       [ 'skia_sanitizer', {
         'skia_clang_build': 1,
         'skia_keep_frame_pointer': 1,
       }, {
         'skia_clang_build%': 0,
         'skia_keep_frame_pointer%': 0,
       }],
+      [ 'skia_shared_lib == 1 or skia_sanitizer == "thread" '
+        'or skia_sanitizer == "undefined" or skia_os == "android"', {

[djsollen, 2014/07/18 19:02:25]

does the sanitizer stuff need to be guarded by...
'skia_os in ["linux", "freebsd", "openbsd", "solaris", "nacl", "chromeos"

[scroggo, 2014/07/18 19:06:43]

Good question. I'm guessing we don't ever build the sanitizer unless skia_os is
one of those.

If we add all those checks, might it be cleaner to leave them alone (e.g.
continue to set -fPIC for them inside their own conditions blocks and ignore
them here)?

[mtklein, 2014/07/19 14:49:19]

Right.  No need to guard.  It won't ever be set on OS/toolchains that don't
support it.  For what it's worth, some xSANs work on Linux and Mac now, and will
work on Windows once we get clang there.
If it makes things simpler to think about, I think it's safe to simplify this
condition to 'skia_shared_lib or skia_sanitizer or skia_os == "android"'.  That
is, I think position-independent code should be fine for any sanitizer mode;
it's just _required_ for TSAN and UBSAN.  Right now we only additionally use
ASAN, and I don't think it'll mind being PIC.

As far as testing on our bots goes, I'd be willing to go all the way to making
-fPIC the default in all Skia gyps.  The only place we really want to turn it
off is for things like linking into Chrome, to save space and run a smidge
faster.

[scroggo, 2014/07/22 14:53:36]

Done.
It seems like there are two ways to do this:
- default to skia_pic, but turn it off in chrome (or does chrome ignore
  our common variables? then it just wouldn't be set)
- add it for all of our targets

+          'skia_pic%' : 1,
+        }, {
+          'skia_pic%' : 0,
+        }
+      ],
     ],
 
     # Re-define all variables defined within the level-2 'variables' dict,
     # so that siblings of the level-1 'variables' dict can see them.
     'arm_version%': '<(arm_version)',
     'arm_neon%': '<(arm_neon)',
     'arm_neon_optional%': 0,
     'mips_arch_variant%': 'mips32',
     'mips_dsp%': 0,
     'skia_os%': '<(skia_os)',
@@ skipping 35 matching lines @@
     'skia_moz2d%': 0,
     'skia_crash_handler%':
         '<!(python -c "import os; print os.environ.get(\'CHROME_HEADLESS\', 0)")',
 
     # These are referenced by our .gypi files that list files (e.g. core.gypi)
     #
     'skia_src_path%': '../src',
     'skia_include_path%': '../include',
   },
 }