Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 406553002: Fix SSL browser test for TLS client auth. (Closed)

Created:
6 years, 5 months ago by pneubeck (no reviews)
Modified:
6 years, 5 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix SSL browser test for TLS client auth. Reenables SSLUITest.TestWSSClientCert BUG=159985, 329735, 210525 R=rsleevi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284432

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Splitted CL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -12 lines) Patch
M chrome/browser/ssl/ssl_browser_tests.cc View 3 chunks +33 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pneubeck (no reviews)
ptal (should be finally the last test cleanup)
6 years, 5 months ago (2014-07-18 13:27:11 UTC) #1
Ryan Sleevi
How is that first bug related?
6 years, 5 months ago (2014-07-18 19:24:01 UTC) #2
Ryan Sleevi
To save a round-trip: This LGTM, but I suspect the testserver.py fix can/should have been ...
6 years, 5 months ago (2014-07-18 19:34:58 UTC) #3
pneubeck (no reviews)
On 2014/07/18 19:34:58, Ryan Sleevi wrote: > To save a round-trip: This LGTM, but I ...
6 years, 5 months ago (2014-07-19 08:49:53 UTC) #4
pneubeck (no reviews)
https://codereview.chromium.org/406553002/diff/40001/chrome/browser/ssl/ssl_browser_tests.cc File chrome/browser/ssl/ssl_browser_tests.cc (left): https://codereview.chromium.org/406553002/diff/40001/chrome/browser/ssl/ssl_browser_tests.cc#oldcode726 chrome/browser/ssl/ssl_browser_tests.cc:726: // Disabled: http://crbug.com/159985 here it refers to the bug ...
6 years, 5 months ago (2014-07-21 06:43:57 UTC) #5
pneubeck (no reviews)
6 years, 5 months ago (2014-07-21 15:34:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r284432 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698