cc: Change TileManager iterators to be queues.

cc/resources/eviction_tile_priority_queue.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CC_RESOURCES_EVICTION_TILE_PRIORITY_QUEUE_H_
+#define CC_RESOURCES_EVICTION_TILE_PRIORITY_QUEUE_H_
+
+#include <utility>
+#include <vector>
+
+#include "cc/base/cc_export.h"
+#include "cc/layers/picture_layer_impl.h"
+#include "cc/resources/tile_priority.h"
+
+namespace cc {
+
+class CC_EXPORT EvictionTilePriorityQueue {
+ public:
+  struct PairedPictureLayerQueue {
+    PairedPictureLayerQueue();

[reveman, 2014/07/19 00:45:50]

How about we pass a PictureLayerImpl::Pair ref and tree priority to this ctor? I
think that will clean up ::Build a bit.

[vmpstr, 2014/07/20 01:15:04]

Done.

+    ~PairedPictureLayerQueue();
+
+    Tile* Top(TreePriority tree_priority);
+    bool IsEmpty() const;
+    void Pop(TreePriority tree_priority);

[reveman, 2014/07/19 00:45:50]

Please reorder these based on typical usage (IsEmpty,Top,Pop) and make it
consistent (the order below is different). Please make sure the order of
implementations in .cc files match too.

[vmpstr, 2014/07/20 01:15:04]

Done.

+
+    PictureLayerImpl::LayerEvictionTileIterator* NextTileIterator(
+        TreePriority tree_priority);
+
+    PictureLayerImpl::LayerEvictionTileIterator active_iterator;
+    PictureLayerImpl::LayerEvictionTileIterator pending_iterator;
+
+    // TODO(vmpstr): Investigate removing this.
+    std::vector<Tile*> returned_shared_tiles;
+  };
+
+  EvictionTilePriorityQueue();
+  ~EvictionTilePriorityQueue();
+
+  void Build(const std::vector<PictureLayerImpl::Pair>& paired_layers,
+             TreePriority tree_priority);
+  void Reset();
+
+  void Pop();
+  bool IsEmpty() const;
+  Tile* Top();

[reveman, 2014/07/19 00:45:50]

reorder

[vmpstr, 2014/07/20 01:15:04]

Done.

+
+ private:
+  std::vector<PairedPictureLayerQueue> paired_queues_;
+  TreePriority tree_priority_;
+
+  DISALLOW_COPY_AND_ASSIGN(EvictionTilePriorityQueue);
+};
+
+}  // namespace cc
+
+#endif  // CC_RESOURCES_EVICTION_TILE_PRIORITY_QUEUE_H_