Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 406523006: Fix GetAMDVideoCardInfo() linkage for Chrome non-Official builds. (Closed)

Created:
6 years, 5 months ago by miu
Modified:
6 years, 5 months ago
Reviewers:
Zhenyao Mo, piman
CC:
chromium-reviews, piman+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix GetAMDVideoCardInfo() linkage for Chrome non-Official builds. Both BULID files and source code were checking for a Chrome-branded build, but not also an Official build type. BUG=388419 TBR=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284609

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M gpu/config/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_info_collector_win.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M gpu/gpu_config.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
miu
PTAL.
6 years, 5 months ago (2014-07-19 04:26:51 UTC) #1
Zhenyao Mo
On 2014/07/19 04:26:51, miu wrote: > PTAL. LGTM
6 years, 5 months ago (2014-07-21 17:12:05 UTC) #2
miu
The CQ bit was checked by miu@chromium.org
6 years, 5 months ago (2014-07-21 21:12:13 UTC) #3
miu
The CQ bit was unchecked by miu@chromium.org
6 years, 5 months ago (2014-07-21 21:13:48 UTC) #4
miu
TBR'ing piman@ for trivial build file change: gpu/gpu_config.gypi
6 years, 5 months ago (2014-07-21 21:16:28 UTC) #5
miu
The CQ bit was checked by miu@chromium.org
6 years, 5 months ago (2014-07-21 21:16:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/406523006/1
6 years, 5 months ago (2014-07-21 21:17:29 UTC) #7
piman
lgtm
6 years, 5 months ago (2014-07-21 21:21:59 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 01:42:48 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 03:15:16 UTC) #10
Message was sent while issue was closed.
Change committed as 284609

Powered by Google App Engine
This is Rietveld 408576698