Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1912)

Unified Diff: Tools/GardeningServer/ui/ct-builder-grid.html

Issue 406523004: Sheriff-o-matic: Move BUILDING builder row to end (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Tools/GardeningServer/ui/ct-builder-grid-tests.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/ui/ct-builder-grid.html
diff --git a/Tools/GardeningServer/ui/ct-builder-grid.html b/Tools/GardeningServer/ui/ct-builder-grid.html
index f0a16544c2c9dbbe785df571264b99140ce7a3a0..ab9a6d339cff79d73339a1de38c2d0d00c67f725 100644
--- a/Tools/GardeningServer/ui/ct-builder-grid.html
+++ b/Tools/GardeningServer/ui/ct-builder-grid.html
@@ -27,11 +27,8 @@ found in the LICENSE file.
tbody td {
padding: 2px;
- width: 40%;
- }
-
- tbody tr td:first-child {
vertical-align: top;
+ width: 40%;
}
tr :first-child span {
@@ -79,7 +76,7 @@ found in the LICENSE file.
</tr>
</thead>
<tbody>
- <template repeat="{{ type in resultTypes|keys }}">
+ <template repeat="{{ type in resultTypes|resultTypeKeys }}">
<tr>
<td class="{{ type }}">
<span>{{ type }}</span>
@@ -112,6 +109,17 @@ found in the LICENSE file.
return Object.keys(obj).sort();
},
+ resultTypeKeys: function(obj) {
+ // Get the keys, but the BUILDING type should be last.
+ var keys = this.keys(obj);
+ var index = keys.indexOf('BUILDING');
+ if (index != -1) {
+ var buildingResult = keys.splice(index, 1);
+ keys.push(buildingResult[0]);
+ }
+ return keys;
+ },
+
failuresChanged: function() {
// Create a set of builders for each result type (e.g., text, crash).
this.resultTypes = {};
@@ -131,7 +139,6 @@ found in the LICENSE file.
}).bind(this));
}, this);
- // BUILDING builders should appear last.
var buildingType = this._getBuilding(passingRevisions);
if (!Object.isEmpty(buildingType))
this.resultTypes['BUILDING'] = buildingType;
« no previous file with comments | « no previous file | Tools/GardeningServer/ui/ct-builder-grid-tests.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698