Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2452)

Unified Diff: Source/platform/heap/Visitor.h

Issue 406523002: Oilpan: Make sure that vtables for garbage collected mixin objects have (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix non-oilpan compilation Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/heap/Visitor.h
diff --git a/Source/platform/heap/Visitor.h b/Source/platform/heap/Visitor.h
index 73a6d5511aeee34aa0a2dc094fccdefb7bd63d97..f9dffd5ba41ed4aa4411fef73c7e58141b59cdc6 100644
--- a/Source/platform/heap/Visitor.h
+++ b/Source/platform/heap/Visitor.h
@@ -586,8 +586,9 @@ template<typename T> bool ObjectAliveTrait<T>::isAlive(Visitor* visitor, T* obj)
class GarbageCollectedMixin {
public:
- virtual void adjustAndMark(Visitor*) const = 0;
- virtual bool isAlive(Visitor*) const = 0;
+ virtual void adjustAndMark(Visitor*) const { };
zerny-chromium 2014/07/19 07:21:58 DBC we need to extend the plugin checks (or find a
+ virtual bool isAlive(Visitor*) const { return true; };
+ virtual void trace(Visitor*) { }
};
#define USING_GARBAGE_COLLECTED_MIXIN(TYPE) \

Powered by Google App Engine
This is Rietveld 408576698