Issue 406453002: Hook up symbol files to the Windows GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 406453002: Hook up symbol files to the Windows GN build. (Closed)

Created:
6 years, 5 months ago by brettw

Modified:
6 years, 5 months ago

Reviewers:
scottmg

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Hook up symbol files to the Windows GN build. Previously the GN Windows build specified the symbol file $pdbfile but this variable was never defined, so the command like would just say "/Fd" and the default one would be used. This patch defines some per-target variables in the ninja file for the toolchain to use. The Windows toolchain uses these to construct C- and C++-specific pdb files (the MS tools can't share between these two) for the current target. BUG= R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284137

Patch Set 1 #

Total comments: 1

Patch Set 2 : tests #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -11 lines)			Patch
M	build/toolchain/win/BUILD.gn	View		3 chunks	+11 lines, -6 lines	0 comments	Download
M	tools/gn/function_toolchain.cc	View		2 chunks	+33 lines, -2 lines	0 comments	Download
M	tools/gn/ninja_binary_target_writer.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	tools/gn/path_output.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	tools/gn/path_output.cc	View	1	1 chunk	+26 lines, -0 lines	0 comments	Download
M	tools/gn/path_output_unittest.cc	View	1	3 chunks	+21 lines, -2 lines	0 comments	Download
M	tools/gn/variables.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scottmg

lgtm https://codereview.chromium.org/406453002/diff/1/tools/gn/path_output.cc File tools/gn/path_output.cc (right): https://codereview.chromium.org/406453002/diff/1/tools/gn/path_output.cc#newcode78 tools/gn/path_output.cc:78: void PathOutput::WriteDir(std::ostream& out, can you add to path_output_unittest.cc ...

6 years, 5 months ago (2014-07-17 21:57:20 UTC) #2

brettw

6 years, 5 months ago (2014-07-18 17:24:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r284137 (presubmit successful).

Expand Messages | Collapse Messages