ash/accelerators/accelerator_filter_unittest.cc - Issue 406413004: Cleanups for aura/test/event_generator.h (resolve TODOs)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/accelerators/accelerator_filter_unittest.cc

Issue 406413004: Cleanups for aura/test/event_generator.h (resolve TODOs) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix gn Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/accelerators/accelerator_controller_unittest.cc ('k') | ash/accelerators/magnifier_key_scroller_unittest.cc » ('j') | ui/aura/test/event_generator_delegate_aura.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/accelerators/accelerator_filter_unittest.cc

diff --git a/ash/accelerators/accelerator_filter_unittest.cc b/ash/accelerators/accelerator_filter_unittest.cc

index 69db83100aff1f3179943de4e166bec2537ff723..db02d824ce27811fa22c2e789602ad78656df66d 100644

--- a/ash/accelerators/accelerator_filter_unittest.cc

+++ b/ash/accelerators/accelerator_filter_unittest.cc

@@ -15,10 +15,10 @@

#include "base/memory/scoped_ptr.h"

#include "testing/gtest/include/gtest/gtest.h"

#include "ui/aura/test/aura_test_base.h"

-#include "ui/aura/test/event_generator.h"

#include "ui/aura/test/test_windows.h"

#include "ui/aura/window.h"

#include "ui/events/event.h"

+#include "ui/events/test/event_generator.h"

#include "ui/gfx/rect.h"

namespace ash {

@@ -31,7 +31,7 @@ TEST_F(AcceleratorFilterTest, TestFilterWithoutFocus) {

const TestScreenshotDelegate* delegate = GetScreenshotDelegate();

EXPECT_EQ(0, delegate->handle_take_screenshot_count());

- aura::test::EventGenerator generator(Shell::GetPrimaryRootWindow());

+ ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow());

// AcceleratorController calls ScreenshotDelegate::HandleTakeScreenshot() when

// VKEY_PRINT is pressed. See kAcceleratorData[] in accelerator_controller.cc.

generator.PressKey(ui::VKEY_PRINT, 0);

@@ -54,7 +54,7 @@ TEST_F(AcceleratorFilterTest, TestFilterWithFocus) {

// AcceleratorFilter should ignore the key events since the root window is

// not focused.

- aura::test::EventGenerator generator(Shell::GetPrimaryRootWindow());

+ ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow());

generator.PressKey(ui::VKEY_PRINT, 0);

EXPECT_EQ(0, delegate->handle_take_screenshot_count());

generator.ReleaseKey(ui::VKEY_PRINT, 0);

@@ -69,7 +69,7 @@ TEST_F(AcceleratorFilterTest, TestCapsLockMask) {

const TestScreenshotDelegate* delegate = GetScreenshotDelegate();

EXPECT_EQ(0, delegate->handle_take_screenshot_count());

- aura::test::EventGenerator generator(Shell::GetPrimaryRootWindow());

+ ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow());

generator.PressKey(ui::VKEY_PRINT, 0);

EXPECT_EQ(1, delegate->handle_take_screenshot_count());

generator.ReleaseKey(ui::VKEY_PRINT, 0);