Cleanup athena's WindowManagerImpl

Cleanup athena's WindowManagerImpl

This CL moves the method implementations out of the WindowManagerImpl class
declaration.

BUG=None
R=flackr
TBR=oshima

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285172

[pkotwicz, 2014-07-23 00:31:17]

flackr@ PTAL

[flackr, 2014-07-23 02:34:20]

lgtm

https://codereview.chromium.org/406393003/diff/1/athena/wm/window_manager_imp...
File athena/wm/window_manager_impl.cc (right):

https://codereview.chromium.org/406393003/diff/1/athena/wm/window_manager_imp...
athena/wm/window_manager_impl.cc:64: class AthenaContainerLayoutManager : public
aura::LayoutManager {
Can you move this class so the implementation immediately follows the
declaration? I guess up since WindowManagerImpl::WindowManagerImpl constructs
this.

[pkotwicz, 2014-07-23 04:25:36]

Rob, can you please take another look?

https://codereview.chromium.org/406393003/diff/1/athena/wm/window_manager_imp...
File athena/wm/window_manager_impl.cc (right):

https://codereview.chromium.org/406393003/diff/1/athena/wm/window_manager_imp...
athena/wm/window_manager_impl.cc:64: class AthenaContainerLayoutManager : public
aura::LayoutManager {
WindowManagerImpl uses AthenaContainerLayoutManager so it isn't that simple

I moved the implementation of AthenaContainerLayoutManager out of the class'
declaration and now everything is groovy

[flackr, 2014-07-23 12:06:13]

slgtm (still looks groovy to me).

[pkotwicz, 2014-07-23 13:36:07]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-07-23 13:37:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/406393003/20001

[commit-bot: I haz the power, 2014-07-23 15:18:14]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-07-23 16:29:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-23 16:29:46]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[pkotwicz, 2014-07-23 18:58:55]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-07-23 19:00:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/406393003/20001

[commit-bot: I haz the power, 2014-07-23 19:06:02]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-07-23 19:10:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-23 19:10:31]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[pkotwicz, 2014-07-23 21:03:52]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-07-23 21:06:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/406393003/20001

[commit-bot: I haz the power, 2014-07-23 21:13:43]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-07-23 21:17:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-23 21:17:59]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[pkotwicz, 2014-07-23 23:31:17]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-07-23 23:33:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/406393003/40001

[commit-bot: I haz the power, 2014-07-24 10:38:52]

Change committed as 285172