Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 406293002: Enable bluetooth on chromeos, win, and mac, but disable on linux unless in the whitelist. The white… (Closed)

Created:
6 years, 5 months ago by Alan Savage
Modified:
6 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enable bluetooth on chromeos, win, and mac, but disable on linux unless in the whitelist. The whitelist includes the HotRod apps. BUG=396117 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285816

Patch Set 1 #

Patch Set 2 : Point to the correct crbug for API whitelist. #

Patch Set 3 : Fix unit_tests and browser_tests by giving them a fixed key and whitelisting the associated app id. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -39 lines) Patch
M chrome/common/extensions/api/_manifest_features.json View 1 2 1 chunk +15 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth/device_events/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth/device_info/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth/discovery_callback/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth/discovery_in_progress/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth/get_device/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth/get_devices/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth/on_adapter_state_changed/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/characteristic_properties/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/characteristic_value_changed/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/connect_in_progress/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/descriptor_value_changed/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/gatt_connection/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/get_characteristic/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/get_characteristics/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/get_descriptor/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/get_descriptors/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/get_included_services/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/get_removed_characteristic/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/get_removed_descriptor/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/get_removed_service/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/get_service/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/get_services/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/permission_denied/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/read_characteristic_value/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/read_descriptor_value/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/reconnect_after_disconnected/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/service_events/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/start_stop_notifications/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/uuid_permission_events/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/uuid_permission_methods/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/write_characteristic_value/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/write_descriptor_value/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_socket/connect/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_socket/listen/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_socket/permission_denied/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/permissions/access_to_devices_bluetooth.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
Alan Savage
6 years, 5 months ago (2014-07-22 17:36:52 UTC) #1
keybuk
lgtm to me in principle, but kalman must review
6 years, 5 months ago (2014-07-22 17:38:51 UTC) #2
not at google - send to devlin
lgtm
6 years, 5 months ago (2014-07-22 17:43:19 UTC) #3
Alan Savage
The CQ bit was checked by asavage@chromium.org
6 years, 5 months ago (2014-07-22 17:50:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asavage@chromium.org/406293002/20001
6 years, 5 months ago (2014-07-22 17:52:05 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 20:58:54 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 21:46:25 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_swarming/builds/1360)
6 years, 5 months ago (2014-07-22 21:46:26 UTC) #8
Alan Savage
On 2014/07/22 21:46:26, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 5 months ago (2014-07-22 22:15:02 UTC) #9
not at google - send to devlin
On 2014/07/22 22:15:02, Alan Savage wrote: > On 2014/07/22 21:46:26, I haz the power (commit-bot) ...
6 years, 5 months ago (2014-07-22 23:53:57 UTC) #10
Alan Savage
PTAL All failing tests now pass locally. I don't have try-bot access (request pending approval).
6 years, 5 months ago (2014-07-25 18:51:03 UTC) #11
armansito
lgtm. Please wait for kalman@ to approve the latest patch set as well.
6 years, 5 months ago (2014-07-25 22:47:34 UTC) #12
not at google - send to devlin
lgtm
6 years, 5 months ago (2014-07-25 22:50:04 UTC) #13
Alan Savage
The CQ bit was checked by asavage@chromium.org
6 years, 5 months ago (2014-07-26 19:43:10 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asavage@chromium.org/406293002/40001
6 years, 5 months ago (2014-07-26 19:44:25 UTC) #15
commit-bot: I haz the power
6 years, 5 months ago (2014-07-26 23:22:31 UTC) #16
Message was sent while issue was closed.
Change committed as 285816

Powered by Google App Engine
This is Rietveld 408576698