Make sure that begin time cannot be greater than

Source/core/svg/animation/SMILTime.h

 /*
  * Copyright (C) 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 16 matching lines @@
 #define SMILTime_h
 
 #include "wtf/Assertions.h"
 #include "wtf/MathExtras.h"
 
 namespace blink {
 
 class SMILTime {
 public:
     SMILTime() : m_time(0) { }
-    SMILTime(double time) : m_time(time) { ASSERT(!std::isnan(time)); }
+    SMILTime(double time, bool checkRange = true) : m_time(checkRange && (time > indefiniteValue) ? indefiniteValue : time) { ASSERT(!std::isnan(time)); }

[fs, 2014/07/22 16:29:37]

I think I'd prefer if this was done at parse-time (parseClockValue) instead. 

I'm getting more and more convinced that using NaN and Inf for these would be
better... That's probably best left for another CL though.

[reni, 2014/07/23 13:42:35]

Do you mean using NaN and Inf instead FLT_MAX and DBL_MAX would be the better
choice?

     SMILTime(const SMILTime& o) : m_time(o.m_time) { }
 
-    static SMILTime unresolved() { return unresolvedValue; }
-    static SMILTime indefinite() { return indefiniteValue; }
+    static SMILTime unresolved() { return SMILTime(unresolvedValue, false); }
+    static SMILTime indefinite() { return SMILTime(indefiniteValue, false); }
 
     SMILTime& operator=(const SMILTime& o) { m_time = o.m_time; return *this; }
     double value() const { return m_time; }
 
     bool isFinite() const { return m_time < indefiniteValue; }
     bool isIndefinite() const { return m_time == indefiniteValue; }
     bool isUnresolved() const { return m_time == unresolvedValue; }
 
 private:
     static const double unresolvedValue;
@@ skipping 53 matching lines @@
 inline bool operator!=(const SMILInterval& a, const SMILInterval& b)
 {
     // Compare the "raw" values since the operator!= for SMILTime always return
     // true for non-finite times.
     return a.begin.value() != b.begin.value() || a.end.value() != b.end.value();
 }
 
 }
 
 #endif // SMILTime_h