Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: Source/core/html/shadow/MediaControlElementTypes.h

Issue 406213002: If the media controls are visible they should always grab clicks (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add missing comment Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/shadow/MediaControlElementTypes.h
diff --git a/Source/core/html/shadow/MediaControlElementTypes.h b/Source/core/html/shadow/MediaControlElementTypes.h
index 700203453a2f845a0291ecf0eb5ea732d06a717d..aa6e78c07066ef35e137037be0da41c03b70ab22 100644
--- a/Source/core/html/shadow/MediaControlElementTypes.h
+++ b/Source/core/html/shadow/MediaControlElementTypes.h
@@ -89,10 +89,13 @@ protected:
void setDisplayType(MediaControlElementType);
+ bool isHidden() const { return m_isHidden; }
+
private:
MediaControls& m_mediaControls;
MediaControlElementType m_displayType;
RawPtrWillBeMember<HTMLElement> m_element;
+ bool m_isHidden;
};
// ----------------------------
@@ -117,10 +120,10 @@ public:
protected:
virtual bool isMediaControlElement() const OVERRIDE FINAL { return true; }
MediaControlInputElement(MediaControls&, MediaControlElementType);
-
philipj_slow 2014/07/22 12:56:24 Accidental removal?
private:
virtual void updateDisplayType() { }
virtual bool isMouseFocusable() const OVERRIDE;
+ void * preDispatchEventHandler(Event*) OVERRIDE FINAL;
philipj_slow 2014/07/22 12:56:24 extra space
};
// ----------------------------

Powered by Google App Engine
This is Rietveld 408576698