Source/core/html/shadow/MediaControlElements.h - Issue 406213002: If the media controls are visible they should always grab clicks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/shadow/MediaControlElements.h

Issue 406213002: If the media controls are visible they should always grab clicks (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix layout test - was hitting overlay play button. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/shadow/MediaControlElements.h

diff --git a/Source/core/html/shadow/MediaControlElements.h b/Source/core/html/shadow/MediaControlElements.h

index 0b3fe71350fdfe482c9c8fe72b7816bc0de81745..10964c127f8cd50cdd746f35ca2607359d3faf22 100644

--- a/Source/core/html/shadow/MediaControlElements.h

+++ b/Source/core/html/shadow/MediaControlElements.h

@@ -54,6 +54,7 @@ private:

void startTimer();

void stopTimer();

void transitionTimerFired(Timer<MediaControlPanelElement>*);

+ virtual bool keepEventInNode(Event*) OVERRIDE;

bool m_isDisplayed;

bool m_opaque;

@@ -128,6 +129,7 @@ private:

virtual const AtomicString& shadowPseudoId() const OVERRIDE;

virtual void defaultEventHandler(Event*) OVERRIDE;

+ virtual bool keepEventInNode(Event*) OVERRIDE;

};

// ----------------------------

@@ -165,6 +167,7 @@ private:

virtual const AtomicString& shadowPseudoId() const OVERRIDE;

virtual void defaultEventHandler(Event*) OVERRIDE;

+ virtual bool keepEventInNode(Event*) OVERRIDE;

};

// ----------------------------

@@ -199,6 +202,7 @@ private:

virtual const AtomicString& shadowPseudoId() const OVERRIDE;

virtual void defaultEventHandler(Event*) OVERRIDE;

+ virtual bool keepEventInNode(Event*) OVERRIDE;

};

// ----------------------------

« no previous file with comments | « Source/core/events/EventTarget.h ('k') | Source/core/html/shadow/MediaControlElements.cpp » ('j') | no next file with comments »