If the media controls are visible they should always grab clicks

Source/core/html/shadow/MediaControlElements.cpp

 /*
  * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 129 matching lines @@
 
     m_opaque = false;
     startTimer();
 }
 
 void MediaControlPanelElement::setIsDisplayed(bool isDisplayed)
 {
     m_isDisplayed = isDisplayed;
 }
 
+bool MediaControlPanelElement::keepEventInShadowDOM(Event* event)
+{
+    const AtomicString& type = event->type();

[philipj_slow, 2014/07/29 11:31:07]

This logic is repeated once, so a static bool isUserInteractionEvent() would be
nice.

[aberent, 2014/07/31 10:52:47]

Done.

+    return type == EventTypeNames::mousedown
+        || type == EventTypeNames::mouseup
+        || type == EventTypeNames::click
+        || type == EventTypeNames::dblclick
+        || event->isKeyboardEvent()
+        || event->isTouchEvent();
+}
+
 // ----------------------------
 
 MediaControlPanelEnclosureElement::MediaControlPanelEnclosureElement(MediaControls& mediaControls)
     // Mapping onto same MediaControlElementType as panel element, since it has similar properties.
     : MediaControlDivElement(mediaControls, MediaControlsPanel)
 {
 }
 
 PassRefPtrWillBeRawPtr<MediaControlPanelEnclosureElement> MediaControlPanelEnclosureElement::create(MediaControls& mediaControls)
 {
@@ skipping 128 matching lines @@
     } else
         hide();
 }
 
 const AtomicString& MediaControlOverlayPlayButtonElement::shadowPseudoId() const
 {
     DEFINE_STATIC_LOCAL(AtomicString, id, ("-webkit-media-controls-overlay-play-button", AtomicString::ConstructFromLiteral));
     return id;
 }
 
+bool MediaControlOverlayPlayButtonElement::keepEventInShadowDOM(Event* event)
+{
+    const AtomicString& type = event->type();
+    return type == EventTypeNames::mousedown
+        || type == EventTypeNames::mouseup
+        || type == EventTypeNames::click
+        || type == EventTypeNames::dblclick
+        || event->isKeyboardEvent()
+        || event->isTouchEvent();
+}
+
 
 // ----------------------------
 
 MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement(MediaControls& mediaControls)
     : MediaControlInputElement(mediaControls, MediaShowClosedCaptionsButton)
 {
 }
 
 PassRefPtrWillBeRawPtr<MediaControlToggleClosedCaptionsButtonElement> MediaControlToggleClosedCaptionsButtonElement::create(MediaControls& mediaControls)
 {
@@ skipping 94 matching lines @@
     setFloatingPointAttribute(maxAttr, std::isfinite(duration) ? duration : 0);
 }
 
 
 const AtomicString& MediaControlTimelineElement::shadowPseudoId() const
 {
     DEFINE_STATIC_LOCAL(AtomicString, id, ("-webkit-media-controls-timeline", AtomicString::ConstructFromLiteral));
     return id;
 }
 
+bool MediaControlTimelineElement::keepEventInShadowDOM(Event* event)
+{
+    // Capture some additional event types in the shadow DOM when on the slider. Note that MediaControlPanelElement::keepEventInShadowDOM
+    // will also be called in this case, so those events will also be captured.
+    const AtomicString& type = event->type();

[philipj_slow, 2014/07/29 11:31:07]

Same here, maybe isUserInteractionEventForSlider()?

[aberent, 2014/07/31 10:52:47]

Done.

+    return type == EventTypeNames::mouseover
+        || type == EventTypeNames::mouseout
+        || type == EventTypeNames::mousemove;
+}
+
 // ----------------------------
 
 MediaControlVolumeSliderElement::MediaControlVolumeSliderElement(MediaControls& mediaControls)
     : MediaControlInputElement(mediaControls, MediaVolumeSlider)
 {
 }
 
 PassRefPtrWillBeRawPtr<MediaControlVolumeSliderElement> MediaControlVolumeSliderElement::create(MediaControls& mediaControls)
 {
     RefPtrWillBeRawPtr<MediaControlVolumeSliderElement> slider = adoptRefWillBeNoop(new MediaControlVolumeSliderElement(mediaControls));
@@ skipping 43 matching lines @@
     if (value().toDouble() != volume)
         setValue(String::number(volume));
 }
 
 const AtomicString& MediaControlVolumeSliderElement::shadowPseudoId() const
 {
     DEFINE_STATIC_LOCAL(AtomicString, id, ("-webkit-media-controls-volume-slider", AtomicString::ConstructFromLiteral));
     return id;
 }
 
+bool MediaControlVolumeSliderElement::keepEventInShadowDOM(Event* event)
+{
+    // Capture some additional event types in the shadow DOM when on the slider. Note that MediaControlPanelElement::keepEventInShadowDOM
+    // will also be called in this case, so those events will also be captured.
+    const AtomicString& type = event->type();
+    return type == EventTypeNames::mouseover
+        || type == EventTypeNames::mouseout
+        || type == EventTypeNames::mousemove;
+}
+
 // ----------------------------
 
 MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement(MediaControls& mediaControls)
     : MediaControlInputElement(mediaControls, MediaEnterFullscreenButton)
 {
 }
 
 PassRefPtrWillBeRawPtr<MediaControlFullscreenButtonElement> MediaControlFullscreenButtonElement::create(MediaControls& mediaControls)
 {
     RefPtrWillBeRawPtr<MediaControlFullscreenButtonElement> button = adoptRefWillBeNoop(new MediaControlFullscreenButtonElement(mediaControls));
@@ skipping 190 matching lines @@
     float fontSize = smallestDimension * 0.05f;
     if (fontSize != m_fontSize) {
         m_fontSize = fontSize;
         setInlineStyleProperty(CSSPropertyFontSize, fontSize, CSSPrimitiveValue::CSS_PX);
     }
 }
 
 // ----------------------------
 
 } // namespace blink