If the media controls are visible they should always grab clicks

Source/core/events/EventPath.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Neither the name of Google Inc. nor the names of its
@@ skipping 40 matching lines @@
         return referenceNode->parentNode();
 
     return referenceNode;
 }
 
 static inline bool inTheSameScope(ShadowRoot* shadowRoot, EventTarget* target)
 {
     return target->toNode() && target->toNode()->treeScope().rootNode() == shadowRoot;
 }
 
-static inline EventDispatchBehavior determineDispatchBehavior(Event* event, ShadowRoot* shadowRoot, EventTarget* target)
+static inline EventDispatchBehavior determineDispatchBehavior(Event* event, Node* current, EventTarget* target)
 {
+    ShadowRoot* shadowRoot = current->containingShadowRoot();
+    if (!shadowRoot)
+        return RetargetEvent;
     // WebKit never allowed selectstart event to cross the the shadow DOM boundary.
     // Changing this breaks existing sites.
     // See https://bugs.webkit.org/show_bug.cgi?id=52195 for details.
     const AtomicString eventType = event->type();
     if (inTheSameScope(shadowRoot, target)
         && (eventType == EventTypeNames::abort
             || eventType == EventTypeNames::change
             || eventType == EventTypeNames::error
             || eventType == EventTypeNames::load
             || eventType == EventTypeNames::reset
             || eventType == EventTypeNames::resize
             || eventType == EventTypeNames::scroll
             || eventType == EventTypeNames::select
             || eventType == EventTypeNames::selectstart))
         return StayInsideShadowDOM;
 
+    if (current->keepEventInShadowDOM(event))
+        return StayInsideShadowDOM;
+
     return RetargetEvent;
 }
 
 EventPath::EventPath(Event* event)
     : m_node(nullptr)
     , m_event(event)
 {
 }
 
 EventPath::EventPath(Node* node)
@@ skipping 22 matching lines @@
 void EventPath::calculatePath()
 {
     ASSERT(m_node);
     ASSERT(m_nodeEventContexts.isEmpty());
     m_node->document().updateDistributionForNodeIfNeeded(const_cast<Node*>(m_node.get()));
 
     Node* current = m_node;
     addNodeEventContext(current);
     if (!m_node->inDocument())
         return;
+    bool stopAtShadowRoot = false;
     while (current) {
-        if (current->isShadowRoot() && m_event && determineDispatchBehavior(m_event, toShadowRoot(current), m_node) == StayInsideShadowDOM)
+        if (m_event && determineDispatchBehavior(m_event, current, m_node) == StayInsideShadowDOM)

[hayato, 2014/07/30 03:19:11]

After the patch, determineDispatchBehavior will be called every time in this
loop.

Can we call that only once per TreeScope as before?

In the current approach, the parent element of MediaControlElement will be also
excluded from the event path even though they are in the same node tree. The
spec doesn't say so. All we have to do is prevent events from propagating into
parent TreeScope, where the *page* exists, I think.

[aberent, 2014/07/31 10:52:47]

See discussion on main review thread.

+            stopAtShadowRoot = true;
+        if (current->isShadowRoot() && stopAtShadowRoot)
             break;
         WillBeHeapVector<RawPtrWillBeMember<InsertionPoint>, 8> insertionPoints;
         collectDestinationInsertionPoints(*current, insertionPoints);
         if (!insertionPoints.isEmpty()) {
             for (size_t i = 0; i < insertionPoints.size(); ++i) {
                 InsertionPoint* insertionPoint = insertionPoints[i];
                 if (insertionPoint->isShadowInsertionPoint()) {
                     ShadowRoot* containingShadowRoot = insertionPoint->containingShadowRoot();
                     ASSERT(containingShadowRoot);
                     if (!containingShadowRoot->isOldest())
@@ skipping 215 matching lines @@
 
 void EventPath::trace(Visitor* visitor)
 {
     visitor->trace(m_nodeEventContexts);
     visitor->trace(m_node);
     visitor->trace(m_event);
     visitor->trace(m_treeScopeEventContexts);
 }
 
 } // namespace