If the media controls are visible they should always grab clicks

Source/core/html/shadow/MediaControlElementTypes.cpp

 /*
  * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 53 matching lines @@
     HTMLElement* element = toHTMLElement(node);
     if (isHTMLInputElement(*element))
         return static_cast<MediaControlInputElement*>(element)->displayType();
     return static_cast<MediaControlDivElement*>(element)->displayType();
 }
 
 MediaControlElement::MediaControlElement(MediaControls& mediaControls, MediaControlElementType displayType, HTMLElement* element)
     : m_mediaControls(mediaControls)
     , m_displayType(displayType)
     , m_element(element)
+    , m_isHidden(false)
 {
 }
 
 HTMLMediaElement& MediaControlElement::mediaElement() const
 {
     return mediaControls().mediaElement();
 }
 
 void MediaControlElement::hide()
 {
     m_element->setInlineStyleProperty(CSSPropertyDisplay, CSSValueNone);

[philipj_slow, 2014/07/22 12:56:24]

Instead of a flag, hide() and show() could be changed to use
setBooleanAttribute(hiddenAttr, true/false) and fastHasAttribute(hiddenAttr)
could be used to check the state.

+    m_isHidden = true;
 }
 
 void MediaControlElement::show()
 {
     m_element->removeInlineStyleProperty(CSSPropertyDisplay);
+    m_isHidden = false;
 }
 
 void MediaControlElement::setDisplayType(MediaControlElementType displayType)
 {
     if (displayType == m_displayType)
         return;
 
     m_displayType = displayType;
     if (RenderObject* object = m_element->renderer())
         object->paintInvalidationForWholeRenderer();
@@ skipping 30 matching lines @@
 {
     return false;
 }
 
 void MediaControlInputElement::trace(Visitor* visitor)
 {
     MediaControlElement::trace(visitor);
     HTMLInputElement::trace(visitor);
 }
 
+void* MediaControlInputElement::preDispatchEventHandler(Event* event)
+{
+    if (event->type() == EventTypeNames::click  && !isHidden()) {

[philipj_slow, 2014/07/22 12:56:24]

Why does it actually matter if it's hidden? How are we getting click events at
all? Also, extra space before &&

+        // If the media control is visible the only sensible behaviour is for the media control to handle the click. Anything
+        // will confuse the user (however the page thinks the click should be handled).
+        event->stopPropagation();
+        return 0;
+    }
+    return HTMLInputElement::preDispatchEventHandler(event);
+}
+
 // ----------------------------
 
 MediaControlTimeDisplayElement::MediaControlTimeDisplayElement(MediaControls& mediaControls, MediaControlElementType displayType)
     : MediaControlDivElement(mediaControls, displayType)
     , m_currentValue(0)
 {
 }
 
 void MediaControlTimeDisplayElement::setCurrentValue(double time)
 {
     m_currentValue = time;
 }
 
 } // namespace blink