Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: dart/tools/dom/src/dart2js_Conversions.dart

Issue 406143004: Bugfix in html_dart2js: Detect window objects in a way compatible with cross domain iframes (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Use 'postMessage', change tools/dom/src/dart2js_Conversions.dart Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/tests/html/cross_domain_iframe_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/dom/src/dart2js_Conversions.dart
diff --git a/dart/tools/dom/src/dart2js_Conversions.dart b/dart/tools/dom/src/dart2js_Conversions.dart
index 41b624e6c2e4be2e647bee146edf7983e9a68017..e56d389fd89b920dc9c3e4e8a7589b88b05fcf69 100644
--- a/dart/tools/dom/src/dart2js_Conversions.dart
+++ b/dart/tools/dom/src/dart2js_Conversions.dart
@@ -20,10 +20,10 @@ EventTarget _convertNativeToDart_EventTarget(e) {
if (e == null) {
return null;
}
- // Assume it's a Window if it contains the setInterval property. It may be
+ // Assume it's a Window if it contains the postMessage property. It may be
// from a different frame - without a patched prototype - so we cannot
// rely on Dart type checking.
- if (JS('bool', r'"setInterval" in #', e)) {
+ if (JS('bool', r'"postMessage" in #', e)) {
var window = _DOMWindowCrossFrame._createSafe(e);
// If it's a native window.
if (window is EventTarget) {
« no previous file with comments | « dart/tests/html/cross_domain_iframe_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698