Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 406143002: webui: Remove unnecessary </include>s everywhere. (Closed)

Created:
6 years, 5 months ago by Dan Beam
Modified:
6 years, 5 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

webui: Remove unnecessary </include>s everywhere. R=tbreisacher@chromium.org TBR=kevers@chromium.org BUG=393873 TEST=no red bots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285088

Patch Set 1 : . #

Total comments: 2

Patch Set 2 : remove stale comment #

Patch Set 3 : GARRRRRR #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -179 lines) Patch
M chrome/browser/resources/about_memory.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/login.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/login_common.js View 1 chunk +25 lines, -25 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe.js View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/extensions/chromeos/kiosk_apps.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/extensions/extension_commands_overlay.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/extensions/extension_error.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/extensions/extension_list.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/extensions/extensions.js View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/resources/inline_login/inline_login.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/options_bundle.js View 1 2 2 chunks +87 lines, -91 lines 0 comments Download
M chrome/browser/resources/pdf/polymer_loader.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/uber/uber_frame.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/user_manager/user_manager.js View 1 chunk +8 lines, -8 lines 0 comments Download
M ui/keyboard/resources/keyboard.js View 1 chunk +21 lines, -22 lines 0 comments Download
M ui/keyboard/resources/polymer_loader.js View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/webui/resources/js/i18n_template2.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/js/jstemplate_compiled.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
Dan Beam
6 years, 5 months ago (2014-07-22 04:12:47 UTC) #1
Tyler Breisacher (Chromium)
lgtm with nit https://chromiumcodereview.appspot.com/406143002/diff/20001/chrome/browser/resources/options/options_bundle.js File chrome/browser/resources/options/options_bundle.js (right): https://chromiumcodereview.appspot.com/406143002/diff/20001/chrome/browser/resources/options/options_bundle.js#newcode23 chrome/browser/resources/options/options_bundle.js:23: // causing a runtime JS break. ...
6 years, 5 months ago (2014-07-22 04:46:43 UTC) #2
Dan Beam
https://chromiumcodereview.appspot.com/406143002/diff/20001/chrome/browser/resources/options/options_bundle.js File chrome/browser/resources/options/options_bundle.js (right): https://chromiumcodereview.appspot.com/406143002/diff/20001/chrome/browser/resources/options/options_bundle.js#newcode23 chrome/browser/resources/options/options_bundle.js:23: // causing a runtime JS break. On 2014/07/22 04:46:42, ...
6 years, 5 months ago (2014-07-22 16:02:49 UTC) #3
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 5 months ago (2014-07-22 16:02:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/406143002/40001
6 years, 5 months ago (2014-07-22 16:04:57 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 20:13:29 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 20:17:50 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/81567)
6 years, 5 months ago (2014-07-22 20:17:51 UTC) #8
Dan Beam
TBR=kevers@ for ui/keyboard/resources
6 years, 5 months ago (2014-07-22 21:16:54 UTC) #9
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 5 months ago (2014-07-22 21:16:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/406143002/40001
6 years, 5 months ago (2014-07-22 21:18:34 UTC) #11
kevers
ui/keyboard LGTM
6 years, 5 months ago (2014-07-22 22:00:25 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 05:58:44 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 07:32:42 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_swarming/builds/1475)
6 years, 5 months ago (2014-07-23 07:32:43 UTC) #15
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 5 months ago (2014-07-23 17:54:23 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/406143002/60001
6 years, 5 months ago (2014-07-23 17:57:25 UTC) #17
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 00:50:10 UTC) #18
Message was sent while issue was closed. 
Change committed as 285088

Powered by Google App Engine
This is Rietveld 408576698