Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 406093004: Revert of Add ExtensionsTestBrowserContext class for test. (Closed)

Created:
6 years, 5 months ago by James Cook
Modified:
6 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Add ExtensionsTestBrowserContext class for test. (https://codereview.chromium.org/355223002/) Reason for revert: This is breaking the Chrome OS valgrind bots: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20(valgrind)(5) For example: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%285%29/builds/28278 This is a problem with mixing tests that use TestingProfile and TestBrowserContext. See crbug.com/395820 Original issue's description: > Add ExtensionsTestBrowserContext class for test. > and Use ExtensionTestBrowserContext for ImageLoader unittest. > > ExtensionsTestBrowserContext class does > set TestExtensionsBrowserClient from constructor and > call DestroyBrowserContextServices from destructor. > > ExtensionTestBrowserContext will be used instead of TestingProfile. > > R=yoz@chromium.org, rdevlin@chromium.org > BUG=354046 > TEST=unit_tests --gtest_filter=ImageLoaderTest.DeleteExtensionWhileWaitingForCache > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284330 TBR=jamescook@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284567

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -63 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D extensions/browser/extensions_test_browser_context.h View 1 chunk +0 lines, -29 lines 0 comments Download
D extensions/browser/extensions_test_browser_context.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M extensions/browser/image_loader_unittest.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
James Cook
Created Revert of Add ExtensionsTestBrowserContext class for test.
6 years, 5 months ago (2014-07-21 22:23:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/406093004/1
6 years, 5 months ago (2014-07-21 22:24:12 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-21 22:24:12 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-21 22:24:13 UTC) #4
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 5 months ago (2014-07-21 22:32:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/406093004/1
6 years, 5 months ago (2014-07-21 22:33:27 UTC) #6
Yoyo Zhou
LGTM
6 years, 5 months ago (2014-07-21 22:44:08 UTC) #7
commit-bot: I haz the power
Change committed as 284567
6 years, 5 months ago (2014-07-22 00:49:03 UTC) #8
limasdf
Thank you very much for taking care of my previous patch. and I'm sorry that ...
6 years, 5 months ago (2014-07-22 01:00:07 UTC) #9
James Cook
6 years, 5 months ago (2014-07-22 01:11:52 UTC) #10
Message was sent while issue was closed.
On 2014/07/22 01:00:07, limasdf wrote:
> Thank you very much for taking care of my previous patch. and I'm sorry that I
> create a patch having problem.!

No problem. This stuff is very very tricky. I spent most of a day trying to
figure out what was wrong with my patch with these BrowserContext services.

Powered by Google App Engine
This is Rietveld 408576698