Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 406093002: ozone: Remove GetAcceleratedWidget from SurfaceFactoryOzone (Closed)

Created:
6 years, 5 months ago by spang
Modified:
6 years, 5 months ago
Reviewers:
danakj, dnicoara
CC:
chromium-reviews, rjkroege, kalyank, ozone-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

ozone: Remove GetAcceleratedWidget from SurfaceFactoryOzone This API is no longer necessary with the PlatformWindow interface. TEST=built & ran on link_freon BUG=392280 TBR=danakj NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284768

Patch Set 1 #

Total comments: 2

Patch Set 2 : devirtualize #

Patch Set 3 : rebase #

Patch Set 4 : fix test #

Patch Set 5 : fix test #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -44 lines) Patch
M content/browser/compositor/software_output_device_ozone_unittest.cc View 1 2 3 2 chunks +3 lines, -4 lines 0 comments Download
M ui/ozone/platform/caca/caca_window_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/caca/caca_window_manager.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/ozone/platform/dri/dri_surface_factory.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M ui/ozone/platform/dri/dri_surface_factory.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M ui/ozone/platform/dri/dri_window.h View 1 chunk +4 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/dri_window.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/ozone/platform/dri/ozone_platform_dri.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/ozone_platform_gbm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/ozone/platform/egltest/ozone_platform_egltest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/ozone/platform/test/test_window_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/test/test_window_manager.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/ozone/public/surface_factory_ozone.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
spang
on top of https://codereview.chromium.org/402213002/
6 years, 5 months ago (2014-07-21 20:30:40 UTC) #1
dnicoara
lgtm https://codereview.chromium.org/406093002/diff/1/ui/ozone/platform/dri/dri_surface_factory.h File ui/ozone/platform/dri/dri_surface_factory.h (right): https://codereview.chromium.org/406093002/diff/1/ui/ozone/platform/dri/dri_surface_factory.h#newcode43 ui/ozone/platform/dri/dri_surface_factory.h:43: virtual gfx::AcceleratedWidget GetAcceleratedWidget(); nit: drop the "virtual"
6 years, 5 months ago (2014-07-21 20:35:25 UTC) #2
spang
https://codereview.chromium.org/406093002/diff/1/ui/ozone/platform/dri/dri_surface_factory.h File ui/ozone/platform/dri/dri_surface_factory.h (right): https://codereview.chromium.org/406093002/diff/1/ui/ozone/platform/dri/dri_surface_factory.h#newcode43 ui/ozone/platform/dri/dri_surface_factory.h:43: virtual gfx::AcceleratedWidget GetAcceleratedWidget(); On 2014/07/21 20:35:25, dnicoara wrote: > ...
6 years, 5 months ago (2014-07-21 20:38:03 UTC) #3
spang
+danakj for content/browser/compositor
6 years, 5 months ago (2014-07-22 18:59:16 UTC) #4
spang
The CQ bit was checked by spang@chromium.org
6 years, 5 months ago (2014-07-22 21:00:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/406093002/100001
6 years, 5 months ago (2014-07-22 21:02:46 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 21:07:09 UTC) #7
Message was sent while issue was closed. 
Change committed as 284768

Powered by Google App Engine
This is Rietveld 408576698