Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2297)

Unified Diff: chrome/browser/safe_browsing/module_integrity_verifier.h

Issue 406043003: Adding the VerifyModule function (and helpers) to safe browsing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: greg's fixes Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/module_integrity_verifier.h
diff --git a/chrome/browser/safe_browsing/module_integrity_verifier.h b/chrome/browser/safe_browsing/module_integrity_verifier.h
new file mode 100644
index 0000000000000000000000000000000000000000..6ce8daad5808cfd81291334772b0952fe4d1a1e8
--- /dev/null
+++ b/chrome/browser/safe_browsing/module_integrity_verifier.h
@@ -0,0 +1,42 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SAFE_BROWSING_MODULE_INTEGRITY_VERIFIER_H_
+#define CHROME_BROWSER_SAFE_BROWSING_MODULE_INTEGRITY_VERIFIER_H_
+
+#include <stdint.h>
+
+namespace base { namespace win {
csharp 2014/07/30 15:22:08 Each namespace needs to go on its own line
krstnmnlsn 2014/07/30 18:36:07 Okay I'll switch. I was following a couple of exam
csharp 2014/07/30 19:29:42 It is in the Google C++ guide (http://google-style
krstnmnlsn 2014/07/30 21:03:58 Yeah I saw that, I just meant specific to namespac
+class PEImage;
+class PEImageAsData;
+} }
+
+namespace safe_browsing {
+
+// This enum defines the possible module states VerifyModule can return.
+enum ModuleState {
+ MODULE_STATE_UNKNOWN,
+ MODULE_STATE_UNMODIFIED,
+ MODULE_STATE_MODIFIED,
+};
+
+// Helper to grab the addresses and size of the code section of a PEImage.
+// Returns two addresses: one for the dll loaded as a library, the other for the
+// dll loaded as data.
+bool GetCodeAddrsAndSize(const base::win::PEImage& mem_peimage,
+ const base::win::PEImageAsData& disk_peimage,
+ uint8_t** mem_code_addr,
+ uint8_t** disk_code_addr,
+ uint32_t* code_size);
+
+// Helper to count the number of bytes differing between two pointers.
+int CountBytesDiffInPtr(uintptr_t num_a, uintptr_t num_b);
+
+// Examines the code section of the given module in memory and on disk, looking
+// for unexpected differences.
+ModuleState VerifyModule(const wchar_t* module_name);
+
+} // namespace safe_browsing
+
+#endif // CHROME_BROWSER_SAFE_BROWSING_MODULE_INTEGRITY_VERIFIER_H_

Powered by Google App Engine
This is Rietveld 408576698