Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: tools/diagnose-me.py

Issue 40603004: Add 'quick-check' option to install-build-deps.sh (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review update Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/install-build-deps.sh ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/diagnose-me.py
diff --git a/tools/diagnose-me.py b/tools/diagnose-me.py
index bbd9429cb1e241f3e448d8638355ae43847ed724..970da8a52aed1af854c030eca79e3b85f2fab79c 100755
--- a/tools/diagnose-me.py
+++ b/tools/diagnose-me.py
@@ -79,6 +79,20 @@ def CheckPathNinja():
return None
+@Check("build dependencies are satisfied")
+def CheckBuildDeps():
+ script_path = os.path.join(
+ os.path.dirname(os.path.dirname(os.path.abspath(__file__))), 'build',
+ 'install-build-deps.sh')
+ proc = subprocess.Popen([script_path, '--quick-check'],
+ stdout=subprocess.PIPE)
+ stdout = proc.communicate()[0]
+ if 'WARNING' in stdout:
+ return ("Your build dependencies are out-of-date.\n"
+ "Run '" + script_path + "' to update.")
+ return None
+
+
def RunChecks():
for name, check in all_checks:
sys.stdout.write("* Checking %s: " % name)
« no previous file with comments | « build/install-build-deps.sh ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698