content/public/browser/android/content_view_core.h - Issue 406023002: Restructuring NavigationController functionalities from ContentViewCore to NavigationController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/android/content_view_core.h

Issue 406023002: Restructuring NavigationController functionalities from ContentViewCore to NavigationController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed review comments and build breaks of chrome_shell Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigation_controller_android.cc ('K') | « content/public/android/java/src/org/chromium/content_public/browser/NavigationController.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/android/content_view_core.h

diff --git a/content/public/browser/android/content_view_core.h b/content/public/browser/android/content_view_core.h

index 550757102a779c66a25985839e6e67e277009697..318de72e8200ea26598eded809efd39276bd36e4 100644

--- a/content/public/browser/android/content_view_core.h

+++ b/content/public/browser/android/content_view_core.h

@@ -48,7 +48,6 @@ class CONTENT_EXPORT ContentViewCore {

virtual ui::ViewAndroid* GetViewAndroid() const = 0;

virtual ui::WindowAndroid* GetWindowAndroid() const = 0;

virtual scoped_refptr<cc::Layer> GetLayer() const = 0;

- virtual void LoadUrl(NavigationController::LoadURLParams& params) = 0;

virtual void ShowPastePopup(int x, int y) = 0;

// Request a scaled content readback. The result is passed through the