content/public/android/java/src/org/chromium/content/browser/NavigationEntry.java - Issue 406023002: Restructuring NavigationController functionalities from ContentViewCore to NavigationController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/NavigationEntry.java

Issue 406023002: Restructuring NavigationController functionalities from ContentViewCore to NavigationController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed review comments and build breaks of chrome_shell Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigation_controller_android.cc ('K') | « content/public/android/java/src/org/chromium/content/browser/LoadUrlParams.java ('k') | content/public/android/java/src/org/chromium/content/browser/NavigationHistory.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/NavigationEntry.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/NavigationEntry.java b/content/public/android/java/src/org/chromium/content/browser/NavigationEntry.java

index 605c011069f33b555c1179c046f18ed5d02d3378..25bb0e62e4787fa22fcb2e3ec615bed5e23b721c 100644

--- a/content/public/android/java/src/org/chromium/content/browser/NavigationEntry.java

+++ b/content/public/android/java/src/org/chromium/content/browser/NavigationEntry.java

@@ -21,7 +21,7 @@ public class NavigationEntry {

/**

* Default constructor.

- protected NavigationEntry(int index, String url, String virtualUrl, String originalUrl,

+ public NavigationEntry(int index, String url, String virtualUrl, String originalUrl,

String title, Bitmap favicon) {

mIndex = index;

mUrl = url;