content/public/android/java/src/org/chromium/content/browser/NavigationHistory.java - Issue 406023002: Restructuring NavigationController functionalities from ContentViewCore to NavigationController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/NavigationHistory.java

Issue 406023002: Restructuring NavigationController functionalities from ContentViewCore to NavigationController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed review comments. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java ('K') | « content/public/android/java/src/org/chromium/content/browser/NavigationEntry.java ('k') | content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java » ('j') | content/public/browser/android/content_view_core.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/NavigationHistory.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/NavigationHistory.java b/content/public/android/java/src/org/chromium/content/browser/NavigationHistory.java

index 6e4347bfc5f36d0f97d8e17da7a0dbdbebc05996..e6f902c2d0c8d6efd35cfa0afaba6654f6717de2 100644

--- a/content/public/android/java/src/org/chromium/content/browser/NavigationHistory.java

+++ b/content/public/android/java/src/org/chromium/content/browser/NavigationHistory.java

@@ -16,11 +16,11 @@ public class NavigationHistory {

private final ArrayList<NavigationEntry> mEntries = new ArrayList<NavigationEntry>();

private int mCurrentEntryIndex;

- protected void addEntry(NavigationEntry entry) {

+ public void addEntry(NavigationEntry entry) {

mEntries.add(entry);

}

- /* package */ void setCurrentEntryIndex(int currentEntryIndex) {

+ public void setCurrentEntryIndex(int currentEntryIndex) {

mCurrentEntryIndex = currentEntryIndex;

}