chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java - Issue 406023002: Restructuring NavigationController functionalities from ContentViewCore to NavigationController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java

Issue 406023002: Restructuring NavigationController functionalities from ContentViewCore to NavigationController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased the patch with findbugs_known_bugs.txt changes. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelector.java ('k') | chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java

index e57d34f3c42e91d524bfff2705474808e63474be..fdbf7b81d046ed860b1d0a53f8f6a8397594ab79 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java

@@ -14,10 +14,10 @@ import org.chromium.base.test.util.UrlUtils;

import org.chromium.chrome.shell.ChromeShellActivity;

import org.chromium.chrome.shell.ChromeShellTestBase;

import org.chromium.content.browser.NavigationClient;

-import org.chromium.content.browser.NavigationEntry;

-import org.chromium.content.browser.NavigationHistory;

import org.chromium.content.browser.test.util.Criteria;

import org.chromium.content.browser.test.util.CriteriaHelper;

+import org.chromium.content_public.browser.NavigationEntry;

+import org.chromium.content_public.browser.NavigationHistory;

import java.util.concurrent.Callable;

import java.util.concurrent.ExecutionException;

@@ -41,7 +41,7 @@ public class NavigationPopupTest extends ChromeShellTestBase {

// Exists solely to expose protected methods to this test.

private static class TestNavigationHistory extends NavigationHistory {

@Override

- protected void addEntry(NavigationEntry entry) {

+ public void addEntry(NavigationEntry entry) {

super.addEntry(entry);

}