Restructuring NavigationController functionalities from ContentViewCore to NavigationController

content/public/browser/android/content_view_core.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_ANDROID_CONTENT_VIEW_CORE_H_
 #define CONTENT_PUBLIC_BROWSER_ANDROID_CONTENT_VIEW_CORE_H_
 
 #include <jni.h>
 
 #include "base/android/scoped_java_ref.h"
@@ skipping 29 matching lines @@
  public:
   // Returns the existing ContentViewCore for |web_contents|, or NULL.
   static ContentViewCore* FromWebContents(WebContents* web_contents);
   static ContentViewCore* GetNativeContentViewCore(JNIEnv* env, jobject obj);
 
   virtual WebContents* GetWebContents() const = 0;
   virtual base::android::ScopedJavaLocalRef<jobject> GetJavaObject() = 0;
   virtual ui::ViewAndroid* GetViewAndroid() const = 0;
   virtual ui::WindowAndroid* GetWindowAndroid() const = 0;
   virtual scoped_refptr<cc::Layer> GetLayer() const = 0;
-  virtual void LoadUrl(NavigationController::LoadURLParams& params) = 0;

[Yaron, 2014/07/23 18:58:38]

I tried patching this in locally and it doesn't compile. There's a reference to
this from tab_android.cc (which is easy enough to fix). Please make sure to
build locally before requesting a review.

[AKVT, 2014/07/24 07:47:24]

I had done only content_shell_apk build for verifying changes. I will execute
full build in future changes for catching compilation issues.

   virtual void ShowPastePopup(int x, int y) = 0;
 
   // Request a scaled content readback. The result is passed through the
   // callback. The boolean parameter indicates whether the readback was a
   // success or not. The content is passed through the SkBitmap parameter.
   virtual void GetScaledContentBitmap(
       float scale,
       jobject bitmap_config,
       gfx::Rect src_rect,
       const base::Callback<void(bool, const SkBitmap&)>& result_callback) = 0;
@@ skipping 14 matching lines @@
                                 int start_offset,
                                 int end_offset)>& callback) = 0;
 
  protected:
   virtual ~ContentViewCore() {};
 };
 
 };  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_ANDROID_CONTENT_VIEW_CORE_H_